Skip to content

Commit

Permalink
Merge pull request #324 from C2FO/issue319
Browse files Browse the repository at this point in the history
Fix for #319
  • Loading branch information
doug-martin authored Feb 14, 2020
2 parents 2904cb0 + 72de715 commit 6569c8b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions History.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# v4.0.3

* [FIXED] Issue where invalid rows were not accounted for when skipRows was set [#317](https://github.com/C2FO/fast-csv/issues/317)
* [FIXED] Issue where readableObjectMode was not set to false when formatting [#319](https://github.com/C2FO/fast-csv/issues/319)

# v4.0.2

Expand Down
2 changes: 1 addition & 1 deletion packages/format/src/CsvFormatterStream.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ export class CsvFormatterStream<I extends Row, O extends Row> extends Transform
private hasWrittenBOM = false;

public constructor(formatterOptions: FormatterOptions<I, O>) {
super({ objectMode: formatterOptions.objectMode });
super({ writableObjectMode: formatterOptions.objectMode });
this.formatterOptions = formatterOptions;
this.rowFormatter = new RowFormatter(formatterOptions);
// if writeBOM is false then set to true
Expand Down

0 comments on commit 6569c8b

Please sign in to comment.