We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug The whole CsvFormatterStream is set in objectMode while this is only used for the writable part and not the readable part.
Atm this breaks for me as I can't pass CsvFormatterStream to hapi as it doesn't allow me pass a stream in objectMode (https://hapi.dev/api/?v=19.0.5#lifecycle-methods)
Parsing or Formatting?
To Reproduce Atm I'm solving it like this: https://github.com/Salesflare/hapi-csv/blob/cors-and-lifecycle-fix/lib/index.js#L118 Which is forcing the readableStream off objectMode, which seems to work fine. I also can't pass formatterOptions.objectMode as false as it will set the writable stream off of objectMode as well.
formatterOptions.objectMode
Expected behavior It doesn't set the readable stream in object mode (or at least has a config for this)
Screenshots If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Additional context Add any other context about the problem here.
The text was updated successfully, but these errors were encountered:
I expect this can be fixed by changing
fast-csv/packages/format/src/CsvFormatterStream.ts
Line 14 in 205cb22
to
super({ writableObjectMode: formatterOptions.objectMode });
Sorry, something went wrong.
Fix for #319
72de715
* When formatting only set writableObjectMode
@kanongil Thank you for the including the fix!
The is will be included in v4.0.3
v4.0.3
Merge pull request #324 from C2FO/issue319
6569c8b
published!
doug-martin
dustinsmith1024
No branches or pull requests
Describe the bug
The whole CsvFormatterStream is set in objectMode while this is only used for the writable part and not the readable part.
Atm this breaks for me as I can't pass CsvFormatterStream to hapi as it doesn't allow me pass a stream in objectMode (https://hapi.dev/api/?v=19.0.5#lifecycle-methods)
Parsing or Formatting?
To Reproduce
Atm I'm solving it like this: https://github.com/Salesflare/hapi-csv/blob/cors-and-lifecycle-fix/lib/index.js#L118
Which is forcing the readableStream off objectMode, which seems to work fine.
I also can't pass
formatterOptions.objectMode
as false as it will set the writable stream off of objectMode as well.Expected behavior
It doesn't set the readable stream in object mode (or at least has a config for this)
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: