Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check whether contrastsheet param is null #200

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Jul 12, 2024

Changes

Remove redundant contrasts param, instead just set contrastsheet to null by default and check whether it is null before trying to create the file/path channel.

Issues

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • [ ] Write unit tests for any new features, bug fixes, or other code changes. testing framework not yet implemented
  • [ ] Update docs if there are any API changes. on hold until before public release
  • [ ] If a new nextflow process is implemented, define the process container and stub.
  • Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

@kelly-sovacool kelly-sovacool marked this pull request as ready for review July 12, 2024 18:03
@kelly-sovacool kelly-sovacool self-assigned this Jul 15, 2024
@kelly-sovacool kelly-sovacool merged commit 97ac019 into main Jul 15, 2024
2 of 4 checks passed
@kelly-sovacool kelly-sovacool deleted the iss-190-kls branch July 15, 2024 13:11
@kelly-sovacool kelly-sovacool added this to the 2024-07 milestone Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change {params.contrast} to be TRUE/FALSE rather than input file
1 participant