Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded abstractions in model code (2) #207

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

damonbayer
Copy link
Collaborator

Redo of #187, which ended up with a mangled git history that I couldn't resolve.

Cleaning up this model in preparation for #202.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.39%. Comparing base (71228e5) to head (a2beff5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
- Coverage   92.51%   92.39%   -0.12%     
==========================================
  Files          40       40              
  Lines         895      881      -14     
==========================================
- Hits          828      814      -14     
  Misses         67       67              
Flag Coverage Δ
unittests 92.39% <100.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@damonbayer damonbayer requested a review from sbidari June 20, 2024 19:56
Copy link
Collaborator

@AFg6K7h4fhy2 AFg6K7h4fhy2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable clarification and removal of sample() wrappers are appropriate and useful. Thank you. Hanging colon conversation addressed; due to pre-commit hooks, either black or ruff.

@damonbayer damonbayer merged commit 4e707f5 into main Jun 20, 2024
7 of 8 checks passed
@damonbayer damonbayer deleted the dmb_remove_abstractions_from_models2 branch June 20, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants