Rename SeedInfectionsExponential For Clarity
#251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AFg6K7h4fhy2
changed the title
SeedInfectionsExponential For Clarity
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #251 +/- ##
=======================================
Coverage 92.69% 92.69%
=======================================
Files 40 40
Lines 904 904
=======================================
Hits 838 838
Misses 66 66
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I would prefer |
Okay, will do. |
AFg6K7h4fhy2
requested review from
dylanhmorris,
damonbayer and
gvegayon
as code owners
damonbayer
approved these changes
Jul 8, 2024
gvegayon
added a commit
that referenced
this pull request
Jul 10, 2024
* Fix docstring for compute_infections_from_rt_with_feedback() (#246) * Update actions/upload-artifact version in website.yaml (#247) * Rename `SeedInfectionsExponential` For Clarity (#251) * name change SeedInfectionsExponential to SeedInfectionsViaExpGrowth * last changed name in __init__ in latent * rename * Changing `Model.sample` To `Model.model` (#248) * initial changes for purposes of creating PR * alias for sample for use in NUTS kernel * change back pyproject.toml file * remove placeholder text * predictive call changed from sample to model * Pyrenew tutorial review (#191) * test commit * add prereq and install instructions, rename hospital_admissions_model * add an example showing sample extraction in the basic model * refer tutorials in getting started * remove link from code * add new/changed tutorials to index * clarify python version req * review suggestion * consistent capitalization * re-arranging tutorial * title change --------- Co-authored-by: damonbayer <xum8@cdc.gov> * Add RST to makefile (#250) * Add RST to makefile * fix make for .py tutorials * fix make for ipynb * use python script for post-processing rst files * use python script for post processing rst in github action * fix for numpydoc with post_process_rst * numpydocs post_process_rst * error if not rst file * correct path for post_process_rst * add arviz plot for posterior predictive (#234) * add arviz plot for posterior predictive * add ppc_plot to hosp_model * test prior/posterior_predictive plots * Damon check in * add plot_ppc, plot_lm * fix tests * formatting * more formatting * fix plot_lm output issue * suggestion from code review Co-authored-by: Damon Bayer <xum8@cdc.gov> * Update example_with_datasets.qmd * change plot_lm kwargs * add details on plot_ppc, fig labels and titles * add figure descriptions * code review suggestions Co-authored-by: Damon Bayer <xum8@cdc.gov> * remove link from code * formatting * add prior predictive plot, sample without warning * add prior predictive plot * fix typo * change order of prior/posterior pred distributions --------- Co-authored-by: damonbayer <xum8@cdc.gov> --------- Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com> Co-authored-by: upx3—TM (CFA) <127630341+AFg6K7h4fhy2@users.noreply.github.com> Co-authored-by: Subekshya Bidari <37636707+sbidari@users.noreply.github.com> Co-authored-by: damonbayer <xum8@cdc.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to rename the class
SeedInfectionsExponentialso that users of MSR do not take exponential here to mean involving Exponential distributions but instead take exponential to mean relating to an exponential growth model.