Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove default name arg #306

Conversation

sbidari
Copy link
Collaborator

@sbidari sbidari commented Jul 24, 2024

closes #198

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.80%. Comparing base (e3c0923) to head (afcd81e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #306   +/-   ##
=======================================
  Coverage   92.80%   92.80%           
=======================================
  Files          39       39           
  Lines         903      904    +1     
=======================================
+ Hits          838      839    +1     
  Misses         65       65           
Flag Coverage Δ
unittests 92.80% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbidari sbidari marked this pull request as ready for review July 24, 2024 22:01
Copy link
Collaborator

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbidari!

@damonbayer damonbayer merged commit 4ea2e4b into main Jul 24, 2024
8 checks passed
@damonbayer damonbayer deleted the 198-remove-default-name-arguments-for-numpyro-sites-from-non-model-classes branch July 24, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove default name arguments for NumPyro sites from non-model classes
2 participants