Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Deterministic vars Attribute To value #331

Conversation

AFg6K7h4fhy2
Copy link
Collaborator

@AFg6K7h4fhy2 AFg6K7h4fhy2 commented Jul 25, 2024

As per DHM:

This will make it more consistent with SampledValue, and indeed allow for creating new DeterministicVariable instances by unpacking SampledValue instances (see #262 (comment))

@AFg6K7h4fhy2 AFg6K7h4fhy2 self-assigned this Jul 25, 2024
@AFg6K7h4fhy2 AFg6K7h4fhy2 linked an issue Jul 25, 2024 that may be closed by this pull request
@AFg6K7h4fhy2 AFg6K7h4fhy2 added the clean up Good code that could be better label Jul 25, 2024
@AFg6K7h4fhy2 AFg6K7h4fhy2 added this to the 🦆 Olorotitan milestone Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.80%. Comparing base (b11f270) to head (5fd7f22).

Files Patch % Lines
model/src/pyrenew/deterministic/deterministic.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #331   +/-   ##
=======================================
  Coverage   92.80%   92.80%           
=======================================
  Files          39       39           
  Lines         904      904           
=======================================
  Hits          839      839           
  Misses         65       65           
Flag Coverage Δ
unittests 92.80% <90.90%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AFg6K7h4fhy2 AFg6K7h4fhy2 marked this pull request as ready for review July 25, 2024 22:22
Copy link
Collaborator

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @AFg6K7h4fhy2!

@damonbayer damonbayer merged commit 7fd138d into main Jul 25, 2024
7 of 8 checks passed
@damonbayer damonbayer deleted the 326-rename-the-vars-attribute-of-deterministicvariable-to-value branch July 25, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean up Good code that could be better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename the vars attribute of DeterministicVariable to value
2 participants