Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert md tutorials to rst and copy them to the website #95

Conversation

gvegayon
Copy link
Member

@gvegayon gvegayon commented May 1, 2024

  • Adds a recipe to model/Makefile to copy (and build if needed) the tutorials to the website in rst format.
  • Removes non-human generated files (the build folder).
  • Updates the index of the website to feature the tutorials.

@gvegayon gvegayon linked an issue May 1, 2024 that may be closed by this pull request
3 tasks
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.48%. Comparing base (a7c1349) to head (29858ae).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files          33       33           
  Lines         634      634           
=======================================
  Hits          580      580           
  Misses         54       54           
Flag Coverage Δ
unittests 91.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gvegayon gvegayon marked this pull request as ready for review May 1, 2024 22:13
@gvegayon gvegayon mentioned this pull request May 2, 2024
2 tasks
Copy link
Collaborator

@dylanhmorris dylanhmorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but needs manual conflict resolution @gvegayon

@gvegayon gvegayon linked an issue May 2, 2024 that may be closed by this pull request
@gvegayon
Copy link
Member Author

gvegayon commented May 2, 2024

All conflicts are now solved.

@gvegayon gvegayon requested a review from dylanhmorris May 2, 2024 18:33
dylanhmorris
dylanhmorris previously approved these changes May 2, 2024
model/src/pyrenew/latent/hospitaladmissions.py Outdated Show resolved Hide resolved
Co-authored-by: Dylan H. Morris <dylanhmorris@users.noreply.github.com>
@dylanhmorris
Copy link
Collaborator

@gvegayon looks as through there are some CI issues that need addressing

@gvegayon
Copy link
Member Author

gvegayon commented May 2, 2024

It was pre-commit and codecov is failing (server side). I'll try to re-run it.

@gvegayon gvegayon merged commit c8e7daf into main May 3, 2024
7 of 8 checks passed
@gvegayon gvegayon deleted the 68-compile-demos-under-docs-and-move-compiled-documents-to-the-website branch May 3, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants