-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Human Readable Condition Name #2895
Merged
JNygaard-Skylight
merged 16 commits into
main
from
josh/human-readable-reportable-conditions
Nov 19, 2024
Merged
Human Readable Condition Name #2895
JNygaard-Skylight
merged 16 commits into
main
from
josh/human-readable-reportable-conditions
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JNygaard-Skylight
requested review from
lina-roth,
mcmcgrath13,
angelathe,
gordonfarrell,
austin-hall-skylight and
BobanL
November 18, 2024 15:19
austin-hall-skylight
requested changes
Nov 18, 2024
containers/trigger-code-reference/seed-scripts/seed_rckms_database.py
Outdated
Show resolved
Hide resolved
…m-jnygaard-skylight:CDCgov/phdi into josh/human-readable-reportable-conditions
@ashton-skylight this is ready to be reviewed |
austin-hall-skylight
approved these changes
Nov 19, 2024
@joshnygaard Amazing work! Reviewed |
mcmcgrath13
reviewed
Nov 19, 2024
mcmcgrath13
reviewed
Nov 19, 2024
mcmcgrath13
reviewed
Nov 19, 2024
JNygaard-Skylight
deleted the
josh/human-readable-reportable-conditions
branch
November 19, 2024 16:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
When available, human-readable condition names are used in the eCR library table, the condition summary, and the reportability summary.
Related Issue
Fixes #2235
Acceptance Criteria
Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)
Additional Information
Before
eCR Library
Condition Summary
Reportability Summary
After
eCR Library
Condition Summary
Reportability Summary
Checklist