Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropped support for Python < v3.5 #57

Merged
merged 2 commits into from
Aug 5, 2019
Merged

Dropped support for Python < v3.5 #57

merged 2 commits into from
Aug 5, 2019

Conversation

sfarrens
Copy link
Contributor

  • Removed all dependencies on future
  • Removed imports from builtins
  • Updated documentation
  • Set minimum versions of package dependencies to latest, which only support Python v3.5+
  • Added travis build for Python v3.7
  • Updated package version to 1.4.0

@sfarrens sfarrens added enhancement clean up clean up of small typos etc. labels Jul 10, 2019
@sfarrens sfarrens self-assigned this Jul 10, 2019
@sfarrens sfarrens mentioned this pull request Jul 10, 2019
Closed
2 tasks
@coveralls
Copy link

coveralls commented Jul 10, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 173

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 95.528%
Totals Coverage Status
Change from base Build 172: -0.05%
Covered Lines: 1666
Relevant Lines: 1744
💛 - Coveralls

@sfarrens sfarrens mentioned this pull request Aug 2, 2019
Merged
@sfarrens sfarrens requested a review from zaccharieramzi August 2, 2019 12:11
zaccharieramzi
zaccharieramzi approved these changes Aug 5, 2019
View reviewed changes
Copy link
Collaborator

@zaccharieramzi zaccharieramzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfarrens sfarrens merged commit a9b286d into CEA-COSMIC:master Aug 5, 2019
@sfarrens sfarrens deleted the python3.5+ branch August 5, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaccharieramzi zaccharieramzi zaccharieramzi approved these changes

Assignees

@sfarrens sfarrens

Labels
clean up clean up of small typos etc. enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfarrens @coveralls @zaccharieramzi