Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python3.5+ #96

Merged
merged 10 commits into from
Aug 6, 2019
Merged

Python3.5+ #96

merged 10 commits into from
Aug 6, 2019

Conversation

sfarrens
Copy link
Contributor

@sfarrens sfarrens commented Aug 2, 2019

  • Dropped support for Python v2.7 and v3.4
  • Removed all dependencies on future
  • Removed all hacks for supporting Python v2.7
  • Updated minimum dependency versions

Note that this PR can only be merged after CEA-COSMIC/ModOpt#57

@sfarrens sfarrens added the clean up small corrections and improvements label Aug 2, 2019
@sfarrens sfarrens requested a review from AGrigis August 2, 2019 12:05
@sfarrens sfarrens self-assigned this Aug 2, 2019
AGrigis
AGrigis reviewed Aug 5, 2019
View reviewed changes
.travis.yml Show resolved Hide resolved
@AGrigis
Copy link
Contributor

AGrigis commented Aug 6, 2019 •
edited
Loading

To fix travis you need to install pyqt5. Indeed pyqtgraph does not support PySide2.
I think the best thing to do is to apply the MacOS hack for all platforms:

MACOS_REQUIRES = [
"pyqt5>=5.12.2"
]

@coveralls
Copy link

coveralls commented Aug 6, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 263

  • 5 of 6 (83.33%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 59.646%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pysap/data.py 4 5 80.0%
Files with Coverage Reduction New Missed Lines %
pysap/utils.py 1 77.19%
pysap/configure.py 2 91.67%
Totals Coverage Status
Change from base Build 259: -0.4%
Covered Lines: 1011
Relevant Lines: 1695
💛 - Coveralls

@sfarrens
Copy link
Contributor Author

sfarrens commented Aug 6, 2019

@AGrigis It should be OK now.

@AGrigis AGrigis merged commit a798315 into CEA-COSMIC:master Aug 6, 2019
@sfarrens sfarrens deleted the python3.5+ branch August 6, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AGrigis AGrigis AGrigis left review comments

Assignees

@sfarrens sfarrens

Labels
clean up small corrections and improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfarrens @AGrigis @coveralls