Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix summarize_cprnc_diffs to work with new test scripts #131

Merged
merged 1 commit into from
Aug 27, 2015
Merged

Fix summarize_cprnc_diffs to work with new test scripts #131

merged 1 commit into from
Aug 27, 2015

Conversation

billsacks
Copy link
Member

(1) Get rid of -in_rundir option: now cprnc output is always in the
run directory

(2) Just look at cprnc output files with 'base' in their name

(3) Rework usage message to be correct with new test scripts

Test suite: None
Test baseline: N/A
Test namelist changes: N/A
Test status: N/A

This script is not covered by any system or unit tests. I tested it
manually by running it on a test suite and comparing the output with
the previous version.

Fixes: None

Code review: None

(1) Get rid of -in_rundir option: now cprnc output is always in the
    run directory

(2) Just look at cprnc output files with 'base' in their name

(3) Rework usage message to be correct with new test scripts

Test suite: None
Test baseline: N/A
Test namelist changes: N/A
Test status: N/A

This script is not covered by any system or unit tests. I tested it
manually by running it on a test suite and comparing the output with
the previous version.

Fixes: None

Code review: None
@billsacks
Copy link
Member Author

cc'ing @sholly

@billsacks
Copy link
Member Author

In principle, RMS results could now be obtained from the TestStatus.log files rather than this tool finding them again in the cprnc.out files. However, I didn't do that because:

(a) It was already written to parse the cprnc.out files.

(b) If I remember correctly, the TestStatus.log files contain any RMS entries, from either baseline comparisons or the test itself (e.g., from the exact restart test). I don't think there is an easy way to separate these two sets of entries, at least not without doing some serious parsing of the TestStatus.log file. It can be confusing if these two types of differences are grouped together, so I thought it best to just parse the cprnc.out files directly, so I could restrict this parsing to the base.cprnc.out files.

jedwards4b added a commit that referenced this pull request Aug 27, 2015
Fix summarize_cprnc_diffs to work with new test scripts
@jedwards4b jedwards4b merged commit 117e530 into CESM-Development:master Aug 27, 2015
rljacob added a commit to E3SM-Project/cime that referenced this pull request Aug 31, 2015
Update ACMEs cime to cime 2.1.12

conflicts resolved: use our version of config_compsets.xml

Needed or useful for ACME:
BatchMaker.pm:  more robust mpirun selection, don't ignore -project, CESM-Development#140
Update pio2 cmake build CESM-Development#137
cime unit tests now work when dot is not in path CESM-Development#141
update summarize_cprn_diffs to work with new scripts CESM-Development#131
Change cesm_setup to get list of models from env_run CESM-Development#133
Fix uninitialized value bug in create_test
Various build fixes CESM-Development#120
Move lnd <-> glc coupling into coupler CESM-Development#106
Update batch configuration for edison
Fix finding component history files for baseline gen,comp  CESM-Development#86
Change shr_flux_mods to support CAM aquaplanet CESM-Development#64
Improve cesm_clean and add compiler options helpful for pop/cice CESM-Development#63 and 88
Fix Batch* to allow machines that don't allow direct queue submissions and output the qsub command.
configure uses -cimeroot even with -list CESM-Development#55
Have preview_namelists load modules for chemistry preprocessor.
Fix minor compiler complaints for NAG.
Add environment variable CIME_MODULES_LOADED to prevent module evnironment being loaded more than once
Update dirunal shr_flux code and diurnal ocean feature in docn.  Don't hardwire 30 minute coupling period.

No impact (yet) on ACME:
Workaround for bug in cism-test_coupling cases.  CESM-Development#138
Increase compatability with pio2 build system.  CESM-Development#137
Use more general location for pfUnit CESM-Development#134
Replace large array in shr_expr_parser_mod CESM-Development#130
Fix (unused) dynamic_vector allocation CESM-Development#125
Add -qfloat=nomaf for mira/cetus
Update hobart and edison/cray compiles.
Read in namelists for new modules on task 0 only CESM-Development#123
Add cray compiler on edison CESM-Development#120
Fix mpi_unit_tests on yellowstone CESM-Development#87
Update hobart pelayouts CESM-Development#62
Allow fire emission fluxes CESM-Development#61
Update ExpectedTestFails.xml
Fix hobart path for cprnc
rljacob added a commit to E3SM-Project/cime that referenced this pull request Sep 2, 2015
    Update ACMEs cime to cime 2.0.12

    conflicts resolved: use our version of config_compsets.xml

    Needed or useful for ACME:
    BatchMaker.pm:  more robust mpirun selection, don't ignore -project, CESM-Development#140
    Update pio2 cmake build CESM-Development#137
    cime unit tests now work when dot is not in path CESM-Development#141
    update summarize_cprn_diffs to work with new scripts CESM-Development#131
    Change cesm_setup to get list of models from env_run CESM-Development#133
    Fix uninitialized value bug in create_test
    Various build fixes CESM-Development#120
    Move lnd <-> glc coupling into coupler CESM-Development#106
    Update batch configuration for edison
    Fix finding component history files for baseline gen,comp  CESM-Development#86
    Change shr_flux_mods to support CAM aquaplanet CESM-Development#64
    Improve cesm_clean and add compiler options helpful for pop/cice CESM-Development#63 and 88
    Fix Batch* to allow machines that don't allow direct queue submissions and output the qsub command.
    configure uses -cimeroot even with -list CESM-Development#55
    Have preview_namelists load modules for chemistry preprocessor.
    Fix minor compiler complaints for NAG.
    Add environment variable CIME_MODULES_LOADED to prevent module evnironment being loaded more than once
    Update dirunal shr_flux code and diurnal ocean feature in docn.  Don't hardwire 30 minute coupling period.

    No impact (yet) on ACME:
    Workaround for bug in cism-test_coupling cases.  CESM-Development#138
    Increase compatability with pio2 build system.  CESM-Development#137
    Use more general location for pfUnit CESM-Development#134
    Replace large array in shr_expr_parser_mod CESM-Development#130
    Fix (unused) dynamic_vector allocation CESM-Development#125
    Add -qfloat=nomaf for mira/cetus
    Update hobart and edison/cray compiles.
    Read in namelists for new modules on task 0 only CESM-Development#123
    Add cray compiler on edison CESM-Development#120
    Fix mpi_unit_tests on yellowstone CESM-Development#87
    Update hobart pelayouts CESM-Development#62
    Allow fire emission fluxes CESM-Development#61
    Update ExpectedTestFails.xml
    Fix hobart path for cprnc
@billsacks billsacks deleted the update_summarize_cprnc_diffs2 branch May 10, 2016 19:33
rljacob added a commit to E3SM-Project/cimemctcomps that referenced this pull request Apr 15, 2021
Update ACMEs cime to cime 2.1.12

conflicts resolved: use our version of config_compsets.xml

Needed or useful for ACME:
BatchMaker.pm:  more robust mpirun selection, don't ignore -project, CESM-Development/cime#140
Update pio2 cmake build CESM-Development/cime#137
cime unit tests now work when dot is not in path CESM-Development/cime#141
update summarize_cprn_diffs to work with new scripts CESM-Development/cime#131
Change cesm_setup to get list of models from env_run CESM-Development/cime#133
Fix uninitialized value bug in create_test
Various build fixes CESM-Development/cime#120
Move lnd <-> glc coupling into coupler CESM-Development/cime#106
Update batch configuration for edison
Fix finding component history files for baseline gen,comp  CESM-Development/cime#86
Change shr_flux_mods to support CAM aquaplanet CESM-Development/cime#64
Improve cesm_clean and add compiler options helpful for pop/cice CESM-Development/cime#63 and 88
Fix Batch* to allow machines that don't allow direct queue submissions and output the qsub command.
configure uses -cimeroot even with -list CESM-Development/cime#55
Have preview_namelists load modules for chemistry preprocessor.
Fix minor compiler complaints for NAG.
Add environment variable CIME_MODULES_LOADED to prevent module evnironment being loaded more than once
Update dirunal shr_flux code and diurnal ocean feature in docn.  Don't hardwire 30 minute coupling period.

No impact (yet) on ACME:
Workaround for bug in cism-test_coupling cases.  CESM-Development/cime#138
Increase compatability with pio2 build system.  CESM-Development/cime#137
Use more general location for pfUnit CESM-Development/cime#134
Replace large array in shr_expr_parser_mod CESM-Development/cime#130
Fix (unused) dynamic_vector allocation CESM-Development/cime#125
Add -qfloat=nomaf for mira/cetus
Update hobart and edison/cray compiles.
Read in namelists for new modules on task 0 only CESM-Development/cime#123
Add cray compiler on edison CESM-Development/cime#120
Fix mpi_unit_tests on yellowstone CESM-Development/cime#87
Update hobart pelayouts CESM-Development/cime#62
Allow fire emission fluxes CESM-Development/cime#61
Update ExpectedTestFails.xml
Fix hobart path for cprnc
rljacob added a commit to E3SM-Project/cimemctcomps that referenced this pull request Apr 15, 2021
    Update ACMEs cime to cime 2.0.12

    conflicts resolved: use our version of config_compsets.xml

    Needed or useful for ACME:
    BatchMaker.pm:  more robust mpirun selection, don't ignore -project, CESM-Development/cime#140
    Update pio2 cmake build CESM-Development/cime#137
    cime unit tests now work when dot is not in path CESM-Development/cime#141
    update summarize_cprn_diffs to work with new scripts CESM-Development/cime#131
    Change cesm_setup to get list of models from env_run CESM-Development/cime#133
    Fix uninitialized value bug in create_test
    Various build fixes CESM-Development/cime#120
    Move lnd <-> glc coupling into coupler CESM-Development/cime#106
    Update batch configuration for edison
    Fix finding component history files for baseline gen,comp  CESM-Development/cime#86
    Change shr_flux_mods to support CAM aquaplanet CESM-Development/cime#64
    Improve cesm_clean and add compiler options helpful for pop/cice CESM-Development/cime#63 and 88
    Fix Batch* to allow machines that don't allow direct queue submissions and output the qsub command.
    configure uses -cimeroot even with -list CESM-Development/cime#55
    Have preview_namelists load modules for chemistry preprocessor.
    Fix minor compiler complaints for NAG.
    Add environment variable CIME_MODULES_LOADED to prevent module evnironment being loaded more than once
    Update dirunal shr_flux code and diurnal ocean feature in docn.  Don't hardwire 30 minute coupling period.

    No impact (yet) on ACME:
    Workaround for bug in cism-test_coupling cases.  CESM-Development/cime#138
    Increase compatability with pio2 build system.  CESM-Development/cime#137
    Use more general location for pfUnit CESM-Development/cime#134
    Replace large array in shr_expr_parser_mod CESM-Development/cime#130
    Fix (unused) dynamic_vector allocation CESM-Development/cime#125
    Add -qfloat=nomaf for mira/cetus
    Update hobart and edison/cray compiles.
    Read in namelists for new modules on task 0 only CESM-Development/cime#123
    Add cray compiler on edison CESM-Development/cime#120
    Fix mpi_unit_tests on yellowstone CESM-Development/cime#87
    Update hobart pelayouts CESM-Development/cime#62
    Allow fire emission fluxes CESM-Development/cime#61
    Update ExpectedTestFails.xml
    Fix hobart path for cprnc
rljacob added a commit to E3SM-Project/cimemctcomps that referenced this pull request Apr 16, 2021
Update ACMEs cime to cime 2.1.12

conflicts resolved: use our version of config_compsets.xml

Needed or useful for ACME:
BatchMaker.pm:  more robust mpirun selection, don't ignore -project, CESM-Development/cime#140
Update pio2 cmake build CESM-Development/cime#137
cime unit tests now work when dot is not in path CESM-Development/cime#141
update summarize_cprn_diffs to work with new scripts CESM-Development/cime#131
Change cesm_setup to get list of models from env_run CESM-Development/cime#133
Fix uninitialized value bug in create_test
Various build fixes CESM-Development/cime#120
Move lnd <-> glc coupling into coupler CESM-Development/cime#106
Update batch configuration for edison
Fix finding component history files for baseline gen,comp  CESM-Development/cime#86
Change shr_flux_mods to support CAM aquaplanet CESM-Development/cime#64
Improve cesm_clean and add compiler options helpful for pop/cice CESM-Development/cime#63 and 88
Fix Batch* to allow machines that don't allow direct queue submissions and output the qsub command.
configure uses -cimeroot even with -list CESM-Development/cime#55
Have preview_namelists load modules for chemistry preprocessor.
Fix minor compiler complaints for NAG.
Add environment variable CIME_MODULES_LOADED to prevent module evnironment being loaded more than once
Update dirunal shr_flux code and diurnal ocean feature in docn.  Don't hardwire 30 minute coupling period.

No impact (yet) on ACME:
Workaround for bug in cism-test_coupling cases.  CESM-Development/cime#138
Increase compatability with pio2 build system.  CESM-Development/cime#137
Use more general location for pfUnit CESM-Development/cime#134
Replace large array in shr_expr_parser_mod CESM-Development/cime#130
Fix (unused) dynamic_vector allocation CESM-Development/cime#125
Add -qfloat=nomaf for mira/cetus
Update hobart and edison/cray compiles.
Read in namelists for new modules on task 0 only CESM-Development/cime#123
Add cray compiler on edison CESM-Development/cime#120
Fix mpi_unit_tests on yellowstone CESM-Development/cime#87
Update hobart pelayouts CESM-Development/cime#62
Allow fire emission fluxes CESM-Development/cime#61
Update ExpectedTestFails.xml
Fix hobart path for cprnc
rljacob added a commit to E3SM-Project/cimemctcomps that referenced this pull request Apr 16, 2021
    Update ACMEs cime to cime 2.0.12

    conflicts resolved: use our version of config_compsets.xml

    Needed or useful for ACME:
    BatchMaker.pm:  more robust mpirun selection, don't ignore -project, CESM-Development/cime#140
    Update pio2 cmake build CESM-Development/cime#137
    cime unit tests now work when dot is not in path CESM-Development/cime#141
    update summarize_cprn_diffs to work with new scripts CESM-Development/cime#131
    Change cesm_setup to get list of models from env_run CESM-Development/cime#133
    Fix uninitialized value bug in create_test
    Various build fixes CESM-Development/cime#120
    Move lnd <-> glc coupling into coupler CESM-Development/cime#106
    Update batch configuration for edison
    Fix finding component history files for baseline gen,comp  CESM-Development/cime#86
    Change shr_flux_mods to support CAM aquaplanet CESM-Development/cime#64
    Improve cesm_clean and add compiler options helpful for pop/cice CESM-Development/cime#63 and 88
    Fix Batch* to allow machines that don't allow direct queue submissions and output the qsub command.
    configure uses -cimeroot even with -list CESM-Development/cime#55
    Have preview_namelists load modules for chemistry preprocessor.
    Fix minor compiler complaints for NAG.
    Add environment variable CIME_MODULES_LOADED to prevent module evnironment being loaded more than once
    Update dirunal shr_flux code and diurnal ocean feature in docn.  Don't hardwire 30 minute coupling period.

    No impact (yet) on ACME:
    Workaround for bug in cism-test_coupling cases.  CESM-Development/cime#138
    Increase compatability with pio2 build system.  CESM-Development/cime#137
    Use more general location for pfUnit CESM-Development/cime#134
    Replace large array in shr_expr_parser_mod CESM-Development/cime#130
    Fix (unused) dynamic_vector allocation CESM-Development/cime#125
    Add -qfloat=nomaf for mira/cetus
    Update hobart and edison/cray compiles.
    Read in namelists for new modules on task 0 only CESM-Development/cime#123
    Add cray compiler on edison CESM-Development/cime#120
    Fix mpi_unit_tests on yellowstone CESM-Development/cime#87
    Update hobart pelayouts CESM-Development/cime#62
    Allow fire emission fluxes CESM-Development/cime#61
    Update ExpectedTestFails.xml
    Fix hobart path for cprnc
billsacks pushed a commit to billsacks/cprnc that referenced this pull request Dec 2, 2023
Update ACMEs cime to cime 2.1.12

conflicts resolved: use our version of config_compsets.xml

Needed or useful for ACME:
BatchMaker.pm:  more robust mpirun selection, don't ignore -project, CESM-Development/cime#140
Update pio2 cmake build CESM-Development/cime#137
cime unit tests now work when dot is not in path CESM-Development/cime#141
update summarize_cprn_diffs to work with new scripts CESM-Development/cime#131
Change cesm_setup to get list of models from env_run CESM-Development/cime#133
Fix uninitialized value bug in create_test
Various build fixes CESM-Development/cime#120
Move lnd <-> glc coupling into coupler CESM-Development/cime#106
Update batch configuration for edison
Fix finding component history files for baseline gen,comp  CESM-Development/cime#86
Change shr_flux_mods to support CAM aquaplanet CESM-Development/cime#64
Improve cesm_clean and add compiler options helpful for pop/cice CESM-Development/cime#63 and 88
Fix Batch* to allow machines that don't allow direct queue submissions and output the qsub command.
configure uses -cimeroot even with -list CESM-Development/cime#55
Have preview_namelists load modules for chemistry preprocessor.
Fix minor compiler complaints for NAG.
Add environment variable CIME_MODULES_LOADED to prevent module evnironment being loaded more than once
Update dirunal shr_flux code and diurnal ocean feature in docn.  Don't hardwire 30 minute coupling period.

No impact (yet) on ACME:
Workaround for bug in cism-test_coupling cases.  CESM-Development/cime#138
Increase compatability with pio2 build system.  CESM-Development/cime#137
Use more general location for pfUnit CESM-Development/cime#134
Replace large array in shr_expr_parser_mod CESM-Development/cime#130
Fix (unused) dynamic_vector allocation CESM-Development/cime#125
Add -qfloat=nomaf for mira/cetus
Update hobart and edison/cray compiles.
Read in namelists for new modules on task 0 only CESM-Development/cime#123
Add cray compiler on edison CESM-Development/cime#120
Fix mpi_unit_tests on yellowstone CESM-Development/cime#87
Update hobart pelayouts CESM-Development/cime#62
Allow fire emission fluxes CESM-Development/cime#61
Update ExpectedTestFails.xml
Fix hobart path for cprnc
billsacks pushed a commit to billsacks/cprnc that referenced this pull request Dec 2, 2023
    Update ACMEs cime to cime 2.0.12

    conflicts resolved: use our version of config_compsets.xml

    Needed or useful for ACME:
    BatchMaker.pm:  more robust mpirun selection, don't ignore -project, CESM-Development/cime#140
    Update pio2 cmake build CESM-Development/cime#137
    cime unit tests now work when dot is not in path CESM-Development/cime#141
    update summarize_cprn_diffs to work with new scripts CESM-Development/cime#131
    Change cesm_setup to get list of models from env_run CESM-Development/cime#133
    Fix uninitialized value bug in create_test
    Various build fixes CESM-Development/cime#120
    Move lnd <-> glc coupling into coupler CESM-Development/cime#106
    Update batch configuration for edison
    Fix finding component history files for baseline gen,comp  CESM-Development/cime#86
    Change shr_flux_mods to support CAM aquaplanet CESM-Development/cime#64
    Improve cesm_clean and add compiler options helpful for pop/cice CESM-Development/cime#63 and 88
    Fix Batch* to allow machines that don't allow direct queue submissions and output the qsub command.
    configure uses -cimeroot even with -list CESM-Development/cime#55
    Have preview_namelists load modules for chemistry preprocessor.
    Fix minor compiler complaints for NAG.
    Add environment variable CIME_MODULES_LOADED to prevent module evnironment being loaded more than once
    Update dirunal shr_flux code and diurnal ocean feature in docn.  Don't hardwire 30 minute coupling period.

    No impact (yet) on ACME:
    Workaround for bug in cism-test_coupling cases.  CESM-Development/cime#138
    Increase compatability with pio2 build system.  CESM-Development/cime#137
    Use more general location for pfUnit CESM-Development/cime#134
    Replace large array in shr_expr_parser_mod CESM-Development/cime#130
    Fix (unused) dynamic_vector allocation CESM-Development/cime#125
    Add -qfloat=nomaf for mira/cetus
    Update hobart and edison/cray compiles.
    Read in namelists for new modules on task 0 only CESM-Development/cime#123
    Add cray compiler on edison CESM-Development/cime#120
    Fix mpi_unit_tests on yellowstone CESM-Development/cime#87
    Update hobart pelayouts CESM-Development/cime#62
    Allow fire emission fluxes CESM-Development/cime#61
    Update ExpectedTestFails.xml
    Fix hobart path for cprnc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants