Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround to allow cism-test_coupling cases to pass #138

Merged
merged 2 commits into from
Aug 28, 2015
Merged

Workaround to allow cism-test_coupling cases to pass #138

merged 2 commits into from
Aug 28, 2015

Conversation

billsacks
Copy link
Member

Change ice runoff to liquid in cism-test_coupling cases

This is needed as a workaround for
http://bugs.cgd.ucar.edu/show_bug.cgi?id=2150, until we can fix that
bug more robustly.

Also, remove a test from the expected fail list that no longer fails, due to
this change.

Test suite: The two BG cases that use the cism-test_coupling testmods:
SMS_D_Ld5.T31_g37_gl20.BG1850C5L45BGCIS2.yellowstone_intel.allactive-cism-test_coupling
NCK_Ld5.f19_g16.BGC5L45BGC.yellowstone_intel.allactive-cism-test_coupling
Test baseline: cesm1_4_alpha07a
Test namelist changes: adds 'ice_runoff = .false.' for tests using
these mods
Test status: Potentially changes answers for any tests with this testmods

Fixes: Workaround for bug 2150, but not a real fix for that bug

Code review: None yet

@billsacks
Change ice runoff to liquid in cism-test_coupling cases
08da9e8 
This is needed as a workaround for
http://bugs.cgd.ucar.edu/show_bug.cgi?id=2150, until we can fix that
bug more robustly.

Test suite: The two BG cases that use the cism-test_coupling testmods:
  SMS_D_Ld5.T31_g37_gl20.BG1850C5L45BGCIS2.yellowstone_intel.allactive-cism-test_coupling
  NCK_Ld5.f19_g16.BGC5L45BGC.yellowstone_intel.allactive-cism-test_coupling
Test baseline: cesm1_4_alpha07a
Test namelist changes: adds 'ice_runoff = .false.' for tests using
  these mods
Test status: Potentially changes answers for any tests with this testmods

Fixes: Workaround for bug 2150, but not a real fix for that bug

Code review: None
@billsacks
Remove expected fail
0ad3ebe 
This no longer fails

Test suite: None
Test baseline: N/A
Test namelist changes: N/A
Test status: N/A

Fixes: None

Code review: None
@billsacks
Copy link
Member Author

cc @jedwards4b and @mvertens

@billsacks
Copy link
Member Author

I had wanted to make one more change in this PR: changing this test:

NCK_Ld5.f19_g16.BC5L45BGC.yellowstone_gnu.allactive-cism-test_coupling

to:

NCK_Ld5.f19_g16.BC5L45BGC.yellowstone_gnu.allactive-default

Note that this test does not use CISM, so it should not be using the cism-test_coupling testmods directory. However, despite the fact that the original test passes, the new one (with allactive-default) fails:

31: Opened file ./NCK_Ld5.f19_g16.BC5L45BGC.yellowstone_gnu.allactive-default.150826-165137.clm2_0002.h0.0001-01-02-00000.nc to write 196608
1: Opened file ./NCK_Ld5.f19_g16.BC5L45BGC.yellowstone_gnu.allactive-default.150826-165137.clm2_0001.h0.0001-01-02-00000.nc to write 1638400
121: NetCDF: File exists && NC_NOCLOBBER
121: pio_support::pio_die:: myrank= -1 : ERROR: ionf_mod.F90: 135 : NetCDF: File exists && NC_NOCLOBBER
121:Abort(1) on node 121 (rank 121 in comm 1140850688): application called MPI_Abort(MPI_COMM_WORLD, 1) - process 121

From the PE layout, I think 121 is running atm / ice / cpl (but not lnd)

So I didn't make this change.

@billsacks
Copy link
Member Author

Labeling this as answer changing, but note that it only changes answers for a small number of tests - those using allactive-cism-test_coupling

sholly pushed a commit that referenced this pull request Aug 28, 2015
@shollyucar
Merge pull request #138 from billsacks/fix_cism_test_coupling
8451fe4 
Workaround to allow cism-test_coupling cases to pass
@sholly sholly merged commit 8451fe4 into CESM-Development:master Aug 28, 2015
rljacob added a commit to E3SM-Project/cime that referenced this pull request Aug 31, 2015
@rljacob
Merge tag 'cime2.0.12' into rljacob/update-cime2.0.12
ed6cef1 
Update ACMEs cime to cime 2.1.12

conflicts resolved: use our version of config_compsets.xml

Needed or useful for ACME:
BatchMaker.pm:  more robust mpirun selection, don't ignore -project, CESM-Development#140
Update pio2 cmake build CESM-Development#137
cime unit tests now work when dot is not in path CESM-Development#141
update summarize_cprn_diffs to work with new scripts CESM-Development#131
Change cesm_setup to get list of models from env_run CESM-Development#133
Fix uninitialized value bug in create_test
Various build fixes CESM-Development#120
Move lnd <-> glc coupling into coupler CESM-Development#106
Update batch configuration for edison
Fix finding component history files for baseline gen,comp  CESM-Development#86
Change shr_flux_mods to support CAM aquaplanet CESM-Development#64
Improve cesm_clean and add compiler options helpful for pop/cice CESM-Development#63 and 88
Fix Batch* to allow machines that don't allow direct queue submissions and output the qsub command.
configure uses -cimeroot even with -list CESM-Development#55
Have preview_namelists load modules for chemistry preprocessor.
Fix minor compiler complaints for NAG.
Add environment variable CIME_MODULES_LOADED to prevent module evnironment being loaded more than once
Update dirunal shr_flux code and diurnal ocean feature in docn.  Don't hardwire 30 minute coupling period.

No impact (yet) on ACME:
Workaround for bug in cism-test_coupling cases.  CESM-Development#138
Increase compatability with pio2 build system.  CESM-Development#137
Use more general location for pfUnit CESM-Development#134
Replace large array in shr_expr_parser_mod CESM-Development#130
Fix (unused) dynamic_vector allocation CESM-Development#125
Add -qfloat=nomaf for mira/cetus
Update hobart and edison/cray compiles.
Read in namelists for new modules on task 0 only CESM-Development#123
Add cray compiler on edison CESM-Development#120
Fix mpi_unit_tests on yellowstone CESM-Development#87
Update hobart pelayouts CESM-Development#62
Allow fire emission fluxes CESM-Development#61
Update ExpectedTestFails.xml
Fix hobart path for cprnc
@rljacob rljacob mentioned this pull request Sep 2, 2015
Merged
rljacob added a commit to E3SM-Project/cime that referenced this pull request Sep 2, 2015
@rljacob
Merge branch 'rljacob/update-cime2.0.12' (PR #11)
9b388e3 
    Update ACMEs cime to cime 2.0.12

    conflicts resolved: use our version of config_compsets.xml

    Needed or useful for ACME:
    BatchMaker.pm:  more robust mpirun selection, don't ignore -project, CESM-Development#140
    Update pio2 cmake build CESM-Development#137
    cime unit tests now work when dot is not in path CESM-Development#141
    update summarize_cprn_diffs to work with new scripts CESM-Development#131
    Change cesm_setup to get list of models from env_run CESM-Development#133
    Fix uninitialized value bug in create_test
    Various build fixes CESM-Development#120
    Move lnd <-> glc coupling into coupler CESM-Development#106
    Update batch configuration for edison
    Fix finding component history files for baseline gen,comp  CESM-Development#86
    Change shr_flux_mods to support CAM aquaplanet CESM-Development#64
    Improve cesm_clean and add compiler options helpful for pop/cice CESM-Development#63 and 88
    Fix Batch* to allow machines that don't allow direct queue submissions and output the qsub command.
    configure uses -cimeroot even with -list CESM-Development#55
    Have preview_namelists load modules for chemistry preprocessor.
    Fix minor compiler complaints for NAG.
    Add environment variable CIME_MODULES_LOADED to prevent module evnironment being loaded more than once
    Update dirunal shr_flux code and diurnal ocean feature in docn.  Don't hardwire 30 minute coupling period.

    No impact (yet) on ACME:
    Workaround for bug in cism-test_coupling cases.  CESM-Development#138
    Increase compatability with pio2 build system.  CESM-Development#137
    Use more general location for pfUnit CESM-Development#134
    Replace large array in shr_expr_parser_mod CESM-Development#130
    Fix (unused) dynamic_vector allocation CESM-Development#125
    Add -qfloat=nomaf for mira/cetus
    Update hobart and edison/cray compiles.
    Read in namelists for new modules on task 0 only CESM-Development#123
    Add cray compiler on edison CESM-Development#120
    Fix mpi_unit_tests on yellowstone CESM-Development#87
    Update hobart pelayouts CESM-Development#62
    Allow fire emission fluxes CESM-Development#61
    Update ExpectedTestFails.xml
    Fix hobart path for cprnc
jedwards4b pushed a commit to jedwards4b/cime that referenced this pull request Apr 26, 2016
@jgfouca
Merge remote-tracking branch 'mvertens/mvertens/pytools' (PR CESM-Dev…
712a1c5 
…elopment#138)

* mvertens/mvertens/pytools:
  put in fixes for initializing case_root correctly - but there seems to be a problem in how create_newcase fills in the PROJECT, WALLTIME, etc in env_batch.xml - which is not in create_clone
  updates to create_clone to address comments in first pull request
  updates to create_clone to address comments in first pull request
  pythonized create_clone

Conflicts:
	utils/python/CIME/case.py
@billsacks billsacks deleted the fix_cism_test_coupling branch May 10, 2016 19:30
rljacob added a commit to E3SM-Project/cimemctcomps that referenced this pull request Apr 15, 2021
@rljacob
Merge tag 'cime2.0.12' into rljacob/update-cime2.0.12
7014068 
Update ACMEs cime to cime 2.1.12

conflicts resolved: use our version of config_compsets.xml

Needed or useful for ACME:
BatchMaker.pm:  more robust mpirun selection, don't ignore -project, CESM-Development/cime#140
Update pio2 cmake build CESM-Development/cime#137
cime unit tests now work when dot is not in path CESM-Development/cime#141
update summarize_cprn_diffs to work with new scripts CESM-Development/cime#131
Change cesm_setup to get list of models from env_run CESM-Development/cime#133
Fix uninitialized value bug in create_test
Various build fixes CESM-Development/cime#120
Move lnd <-> glc coupling into coupler CESM-Development/cime#106
Update batch configuration for edison
Fix finding component history files for baseline gen,comp  CESM-Development/cime#86
Change shr_flux_mods to support CAM aquaplanet CESM-Development/cime#64
Improve cesm_clean and add compiler options helpful for pop/cice CESM-Development/cime#63 and 88
Fix Batch* to allow machines that don't allow direct queue submissions and output the qsub command.
configure uses -cimeroot even with -list CESM-Development/cime#55
Have preview_namelists load modules for chemistry preprocessor.
Fix minor compiler complaints for NAG.
Add environment variable CIME_MODULES_LOADED to prevent module evnironment being loaded more than once
Update dirunal shr_flux code and diurnal ocean feature in docn.  Don't hardwire 30 minute coupling period.

No impact (yet) on ACME:
Workaround for bug in cism-test_coupling cases.  CESM-Development/cime#138
Increase compatability with pio2 build system.  CESM-Development/cime#137
Use more general location for pfUnit CESM-Development/cime#134
Replace large array in shr_expr_parser_mod CESM-Development/cime#130
Fix (unused) dynamic_vector allocation CESM-Development/cime#125
Add -qfloat=nomaf for mira/cetus
Update hobart and edison/cray compiles.
Read in namelists for new modules on task 0 only CESM-Development/cime#123
Add cray compiler on edison CESM-Development/cime#120
Fix mpi_unit_tests on yellowstone CESM-Development/cime#87
Update hobart pelayouts CESM-Development/cime#62
Allow fire emission fluxes CESM-Development/cime#61
Update ExpectedTestFails.xml
Fix hobart path for cprnc
rljacob added a commit to E3SM-Project/cimemctcomps that referenced this pull request Apr 15, 2021
@rljacob
Merge branch 'rljacob/update-cime2.0.12' (PR #11)
ae9de62 
    Update ACMEs cime to cime 2.0.12

    conflicts resolved: use our version of config_compsets.xml

    Needed or useful for ACME:
    BatchMaker.pm:  more robust mpirun selection, don't ignore -project, CESM-Development/cime#140
    Update pio2 cmake build CESM-Development/cime#137
    cime unit tests now work when dot is not in path CESM-Development/cime#141
    update summarize_cprn_diffs to work with new scripts CESM-Development/cime#131
    Change cesm_setup to get list of models from env_run CESM-Development/cime#133
    Fix uninitialized value bug in create_test
    Various build fixes CESM-Development/cime#120
    Move lnd <-> glc coupling into coupler CESM-Development/cime#106
    Update batch configuration for edison
    Fix finding component history files for baseline gen,comp  CESM-Development/cime#86
    Change shr_flux_mods to support CAM aquaplanet CESM-Development/cime#64
    Improve cesm_clean and add compiler options helpful for pop/cice CESM-Development/cime#63 and 88
    Fix Batch* to allow machines that don't allow direct queue submissions and output the qsub command.
    configure uses -cimeroot even with -list CESM-Development/cime#55
    Have preview_namelists load modules for chemistry preprocessor.
    Fix minor compiler complaints for NAG.
    Add environment variable CIME_MODULES_LOADED to prevent module evnironment being loaded more than once
    Update dirunal shr_flux code and diurnal ocean feature in docn.  Don't hardwire 30 minute coupling period.

    No impact (yet) on ACME:
    Workaround for bug in cism-test_coupling cases.  CESM-Development/cime#138
    Increase compatability with pio2 build system.  CESM-Development/cime#137
    Use more general location for pfUnit CESM-Development/cime#134
    Replace large array in shr_expr_parser_mod CESM-Development/cime#130
    Fix (unused) dynamic_vector allocation CESM-Development/cime#125
    Add -qfloat=nomaf for mira/cetus
    Update hobart and edison/cray compiles.
    Read in namelists for new modules on task 0 only CESM-Development/cime#123
    Add cray compiler on edison CESM-Development/cime#120
    Fix mpi_unit_tests on yellowstone CESM-Development/cime#87
    Update hobart pelayouts CESM-Development/cime#62
    Allow fire emission fluxes CESM-Development/cime#61
    Update ExpectedTestFails.xml
    Fix hobart path for cprnc
rljacob added a commit to E3SM-Project/cimemctcomps that referenced this pull request Apr 16, 2021
@rljacob
Merge tag 'cime2.0.12' into rljacob/update-cime2.0.12
a74ea79 
Update ACMEs cime to cime 2.1.12

conflicts resolved: use our version of config_compsets.xml

Needed or useful for ACME:
BatchMaker.pm:  more robust mpirun selection, don't ignore -project, CESM-Development/cime#140
Update pio2 cmake build CESM-Development/cime#137
cime unit tests now work when dot is not in path CESM-Development/cime#141
update summarize_cprn_diffs to work with new scripts CESM-Development/cime#131
Change cesm_setup to get list of models from env_run CESM-Development/cime#133
Fix uninitialized value bug in create_test
Various build fixes CESM-Development/cime#120
Move lnd <-> glc coupling into coupler CESM-Development/cime#106
Update batch configuration for edison
Fix finding component history files for baseline gen,comp  CESM-Development/cime#86
Change shr_flux_mods to support CAM aquaplanet CESM-Development/cime#64
Improve cesm_clean and add compiler options helpful for pop/cice CESM-Development/cime#63 and 88
Fix Batch* to allow machines that don't allow direct queue submissions and output the qsub command.
configure uses -cimeroot even with -list CESM-Development/cime#55
Have preview_namelists load modules for chemistry preprocessor.
Fix minor compiler complaints for NAG.
Add environment variable CIME_MODULES_LOADED to prevent module evnironment being loaded more than once
Update dirunal shr_flux code and diurnal ocean feature in docn.  Don't hardwire 30 minute coupling period.

No impact (yet) on ACME:
Workaround for bug in cism-test_coupling cases.  CESM-Development/cime#138
Increase compatability with pio2 build system.  CESM-Development/cime#137
Use more general location for pfUnit CESM-Development/cime#134
Replace large array in shr_expr_parser_mod CESM-Development/cime#130
Fix (unused) dynamic_vector allocation CESM-Development/cime#125
Add -qfloat=nomaf for mira/cetus
Update hobart and edison/cray compiles.
Read in namelists for new modules on task 0 only CESM-Development/cime#123
Add cray compiler on edison CESM-Development/cime#120
Fix mpi_unit_tests on yellowstone CESM-Development/cime#87
Update hobart pelayouts CESM-Development/cime#62
Allow fire emission fluxes CESM-Development/cime#61
Update ExpectedTestFails.xml
Fix hobart path for cprnc
rljacob added a commit to E3SM-Project/cimemctcomps that referenced this pull request Apr 16, 2021
@rljacob
Merge branch 'rljacob/update-cime2.0.12' (PR #11)
453fdf5 
    Update ACMEs cime to cime 2.0.12

    conflicts resolved: use our version of config_compsets.xml

    Needed or useful for ACME:
    BatchMaker.pm:  more robust mpirun selection, don't ignore -project, CESM-Development/cime#140
    Update pio2 cmake build CESM-Development/cime#137
    cime unit tests now work when dot is not in path CESM-Development/cime#141
    update summarize_cprn_diffs to work with new scripts CESM-Development/cime#131
    Change cesm_setup to get list of models from env_run CESM-Development/cime#133
    Fix uninitialized value bug in create_test
    Various build fixes CESM-Development/cime#120
    Move lnd <-> glc coupling into coupler CESM-Development/cime#106
    Update batch configuration for edison
    Fix finding component history files for baseline gen,comp  CESM-Development/cime#86
    Change shr_flux_mods to support CAM aquaplanet CESM-Development/cime#64
    Improve cesm_clean and add compiler options helpful for pop/cice CESM-Development/cime#63 and 88
    Fix Batch* to allow machines that don't allow direct queue submissions and output the qsub command.
    configure uses -cimeroot even with -list CESM-Development/cime#55
    Have preview_namelists load modules for chemistry preprocessor.
    Fix minor compiler complaints for NAG.
    Add environment variable CIME_MODULES_LOADED to prevent module evnironment being loaded more than once
    Update dirunal shr_flux code and diurnal ocean feature in docn.  Don't hardwire 30 minute coupling period.

    No impact (yet) on ACME:
    Workaround for bug in cism-test_coupling cases.  CESM-Development/cime#138
    Increase compatability with pio2 build system.  CESM-Development/cime#137
    Use more general location for pfUnit CESM-Development/cime#134
    Replace large array in shr_expr_parser_mod CESM-Development/cime#130
    Fix (unused) dynamic_vector allocation CESM-Development/cime#125
    Add -qfloat=nomaf for mira/cetus
    Update hobart and edison/cray compiles.
    Read in namelists for new modules on task 0 only CESM-Development/cime#123
    Add cray compiler on edison CESM-Development/cime#120
    Fix mpi_unit_tests on yellowstone CESM-Development/cime#87
    Update hobart pelayouts CESM-Development/cime#62
    Allow fire emission fluxes CESM-Development/cime#61
    Update ExpectedTestFails.xml
    Fix hobart path for cprnc
billsacks pushed a commit to billsacks/cprnc that referenced this pull request Dec 2, 2023
@rljacob
Merge tag 'cime2.0.12' into rljacob/update-cime2.0.12
95b4490 
Update ACMEs cime to cime 2.1.12

conflicts resolved: use our version of config_compsets.xml

Needed or useful for ACME:
BatchMaker.pm:  more robust mpirun selection, don't ignore -project, CESM-Development/cime#140
Update pio2 cmake build CESM-Development/cime#137
cime unit tests now work when dot is not in path CESM-Development/cime#141
update summarize_cprn_diffs to work with new scripts CESM-Development/cime#131
Change cesm_setup to get list of models from env_run CESM-Development/cime#133
Fix uninitialized value bug in create_test
Various build fixes CESM-Development/cime#120
Move lnd <-> glc coupling into coupler CESM-Development/cime#106
Update batch configuration for edison
Fix finding component history files for baseline gen,comp  CESM-Development/cime#86
Change shr_flux_mods to support CAM aquaplanet CESM-Development/cime#64
Improve cesm_clean and add compiler options helpful for pop/cice CESM-Development/cime#63 and 88
Fix Batch* to allow machines that don't allow direct queue submissions and output the qsub command.
configure uses -cimeroot even with -list CESM-Development/cime#55
Have preview_namelists load modules for chemistry preprocessor.
Fix minor compiler complaints for NAG.
Add environment variable CIME_MODULES_LOADED to prevent module evnironment being loaded more than once
Update dirunal shr_flux code and diurnal ocean feature in docn.  Don't hardwire 30 minute coupling period.

No impact (yet) on ACME:
Workaround for bug in cism-test_coupling cases.  CESM-Development/cime#138
Increase compatability with pio2 build system.  CESM-Development/cime#137
Use more general location for pfUnit CESM-Development/cime#134
Replace large array in shr_expr_parser_mod CESM-Development/cime#130
Fix (unused) dynamic_vector allocation CESM-Development/cime#125
Add -qfloat=nomaf for mira/cetus
Update hobart and edison/cray compiles.
Read in namelists for new modules on task 0 only CESM-Development/cime#123
Add cray compiler on edison CESM-Development/cime#120
Fix mpi_unit_tests on yellowstone CESM-Development/cime#87
Update hobart pelayouts CESM-Development/cime#62
Allow fire emission fluxes CESM-Development/cime#61
Update ExpectedTestFails.xml
Fix hobart path for cprnc
billsacks pushed a commit to billsacks/cprnc that referenced this pull request Dec 2, 2023
@rljacob
Merge branch 'rljacob/update-cime2.0.12' (PR #11)
363ffb7 
    Update ACMEs cime to cime 2.0.12

    conflicts resolved: use our version of config_compsets.xml

    Needed or useful for ACME:
    BatchMaker.pm:  more robust mpirun selection, don't ignore -project, CESM-Development/cime#140
    Update pio2 cmake build CESM-Development/cime#137
    cime unit tests now work when dot is not in path CESM-Development/cime#141
    update summarize_cprn_diffs to work with new scripts CESM-Development/cime#131
    Change cesm_setup to get list of models from env_run CESM-Development/cime#133
    Fix uninitialized value bug in create_test
    Various build fixes CESM-Development/cime#120
    Move lnd <-> glc coupling into coupler CESM-Development/cime#106
    Update batch configuration for edison
    Fix finding component history files for baseline gen,comp  CESM-Development/cime#86
    Change shr_flux_mods to support CAM aquaplanet CESM-Development/cime#64
    Improve cesm_clean and add compiler options helpful for pop/cice CESM-Development/cime#63 and 88
    Fix Batch* to allow machines that don't allow direct queue submissions and output the qsub command.
    configure uses -cimeroot even with -list CESM-Development/cime#55
    Have preview_namelists load modules for chemistry preprocessor.
    Fix minor compiler complaints for NAG.
    Add environment variable CIME_MODULES_LOADED to prevent module evnironment being loaded more than once
    Update dirunal shr_flux code and diurnal ocean feature in docn.  Don't hardwire 30 minute coupling period.

    No impact (yet) on ACME:
    Workaround for bug in cism-test_coupling cases.  CESM-Development/cime#138
    Increase compatability with pio2 build system.  CESM-Development/cime#137
    Use more general location for pfUnit CESM-Development/cime#134
    Replace large array in shr_expr_parser_mod CESM-Development/cime#130
    Fix (unused) dynamic_vector allocation CESM-Development/cime#125
    Add -qfloat=nomaf for mira/cetus
    Update hobart and edison/cray compiles.
    Read in namelists for new modules on task 0 only CESM-Development/cime#123
    Add cray compiler on edison CESM-Development/cime#120
    Fix mpi_unit_tests on yellowstone CESM-Development/cime#87
    Update hobart pelayouts CESM-Development/cime#62
    Allow fire emission fluxes CESM-Development/cime#61
    Update ExpectedTestFails.xml
    Fix hobart path for cprnc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sholly sholly

Labels
impact: answer changing topic: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billsacks @sholly