-
Notifications
You must be signed in to change notification settings - Fork 8
integration of RE Galaxy #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
galaxy-re VM didn't have a privileged user (e.g., debian) so we need to create one manually |
| csnt_enable_oidc: true | ||
| csnt_oidc_config_file: "{{ galaxy_config_dir }}/oidc_config.xml" | ||
| csnt_oidc_backends_config_file: "{{ galaxy_config_dir }}/oidc_backends_config.xml" | ||
| csnt_auth_config_file: "{{ galaxy_config_dir }}/auth_conf.xml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is likely not a correct default for instances other than RE?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the same file as the default in sources. I had to use something neutral. But I agree (and commented below) that we need a better way to define common and instance specific templates
| nginx_conf_ssl_certificate_key: /etc/letsencrypt/live/{{ inventory_hostname }}/privkey.pem | ||
|
|
||
| #Install pip docker package for ansible | ||
| pip_install_packages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally let's install these only on instances where we need them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, I moved python-ldap package to the RE configuration. And docker is still needed as long as we need it for rabbitmq container.
| dest: "{{ galaxy_server_dir }}/static/eu_msmt_eosc.svg" | ||
| - src: files/galaxy/static/e-infra_logo.svg | ||
| dest: "{{ galaxy_server_dir }}/static/e-infra_logo.svg" | ||
| - src: files/galaxy/static/images/umbr_programs_icons/RE_header.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all RE files should go to instance-specific vars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the images we should likely just load from a static host and link URL, not include them in Galaxy playbook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if these images are publicly available somewhere. It's just 4 small PNGs, is that so different from some SVG logo files?
|
The way the playbook uses instantiation of galaxy templates and config files in group_vars/galaxyservers.yml is not ideal. Because it defines also configs which RE doesn't need (i.e., oidc stuff). To quickly overcome this I created empty variables in vault but it would be best to find a way how to define only common set of templates and keep the rest instance based. |
…D for RE via distributed object store
|
RE instance requires a few changes in LoginForm.vue and therefore to find out a way how to integrate these into the playbook |
No description provided.