Skip to content

Commit

Permalink
Do not filter on translation table in GO.py when retrieving ensembl d…
Browse files Browse the repository at this point in the history
…ump. (#386)

As far as I'm aware the translation table was previously used because it was needed for the ID mapping.

If we wanted to restricted GO categories by gene type, this would be better done via biotypes.

But probably best to take all GO categories here regardless of gene biotype and to instead encourage people to filter downstream.
  • Loading branch information
snsansom authored and sebastian-luna-valero committed Feb 15, 2018
1 parent d10e43d commit a7c8a5c
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions CGAT/GO.py
Original file line number Diff line number Diff line change
Expand Up @@ -705,12 +705,11 @@ def GetGOStatement(go_type, database, species):

statement = """SELECT DISTINCTROW
gene.stable_id, xref.dbprimary_acc, go.name, 'NA'
FROM gene, transcript, translation,
FROM gene, transcript,
object_xref as o, xref,
%(go_database)s.term AS go,
%(go_database)s.ontology AS ontology
WHERE gene.gene_id = transcript.gene_id
AND transcript.transcript_id = translation.transcript_id
AND transcript.transcript_id = o.ensembl_id
AND o.ensembl_object_type = 'Transcript'
AND xref.xref_id = o.xref_id
Expand Down

0 comments on commit a7c8a5c

Please sign in to comment.