Don't filter on translation table in GO.py when retrieving ensembl dump #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ump. As far as I'm aware the translation table was previously used because it was needed for the ID mapping. If we wanted to restricted GO categories by gene type, this would be better done via biotypes. But probably best to take all GO categories here regardless of gene biotype and to instead encourage people to filter downstream.
|
Thanks, Steve. |
sebastian-luna-valero
added a commit
to cgat-developers/cgat-apps
that referenced
this pull request
May 29, 2018
sebastian-luna-valero
added a commit
to cgat-developers/cgat-apps
that referenced
this pull request
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I'm aware the translation table was previously used because it was needed for the ID mapping.
If we wanted to restricted GO categories by gene type, this would be better done via biotypes.
But probably best to take all GO categories here regardless of gene biotype and to instead encourage people to filter downstream.