Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: changing the tag name creates a new tag #1002

Closed
kbeaugrand opened this issue Jul 29, 2022 · 0 comments · Fixed by #1017
Closed

Bug: changing the tag name creates a new tag #1002

kbeaugrand opened this issue Jul 29, 2022 · 0 comments · Fixed by #1017
Assignees
@hocinehacherouf
Labels
bug Something isn't working
Milestone
S34

Comments

@kbeaugrand
Copy link
Member

Expected Behavior

When changing a tag in the settings, it should change the entity instead of creating a new one.

Current Behavior

Tags are supposed to be unique by its name.
The controller is creating a new tag with a suffix...

Steps to Reproduce

  1. Go to Tag settings page
  2. Change a tag name (not the label)
  3. Click to validate
  4. Refresh the table

Context (Environment)

Portal version: 2.6.0
LoRaWAN Stack version: N/A

Logs

Additional Information
@kbeaugrand kbeaugrand added the bug Something isn't working label Jul 29, 2022
@kbeaugrand kbeaugrand moved this to :pencil: Todo in IoT Hub Portal Aug 1, 2022
@kbeaugrand kbeaugrand added this to the S34 milestone Aug 1, 2022
@hocinehacherouf hocinehacherouf moved this from :pencil: Todo to :construction: In Progress in IoT Hub Portal Aug 1, 2022
@hocinehacherouf hocinehacherouf self-assigned this Aug 1, 2022
hocinehacherouf added a commit that referenced this issue Aug 2, 2022
@hocinehacherouf
Disable the edition of existing tags names #1002
6b86fc2
@hocinehacherouf hocinehacherouf mentioned this issue Aug 2, 2022
Merged
9 tasks
hocinehacherouf added a commit that referenced this issue Aug 2, 2022
@hocinehacherouf
Add unit test ClickOnAddNewTagShouldAddNewTag #1002
543df9d
@hocinehacherouf hocinehacherouf moved this from :construction: In Progress to :speech_balloon: Ready for Review in IoT Hub Portal Aug 2, 2022
kbeaugrand pushed a commit that referenced this issue Aug 2, 2022
@hocinehacherouf
Disable the edition of existing tags names on Device Tags Settings page
ae68025 
#1002 (#1017)

* Disable the edition of existing tags names  #1002

* Add unit test ClickOnAddNewTagShouldAddNewTag #1002
@hocinehacherouf hocinehacherouf moved this from :speech_balloon: Ready for Review to :rocket: Ready in IoT Hub Portal Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hocinehacherouf hocinehacherouf

Labels
bug Something isn't working
Projects
IoT Hub Portal
Status: 🚀 Ready
Milestone
S34
Development

Successfully merging a pull request may close this issue.

Disable the edition of existing tags names on Device Tags Settings page #1002 CGI-FR/IoT-Hub-Portal
2 participants
@kbeaugrand @hocinehacherouf