Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the edition of existing tags names on Device Tags Settings page #1002 #1017

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

hocinehacherouf
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #1017 (543df9d) into main (efb46db) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1017      +/-   ##
==========================================
+ Coverage   85.10%   85.26%   +0.15%     
==========================================
  Files         176      177       +1     
  Lines        5802     5816      +14     
==========================================
+ Hits         4938     4959      +21     
+ Misses        864      857       -7     
Impacted Files Coverage Δ
...AzureIoTHub.Portal/Client/Models/DeviceTagModel.cs 100.00% <100.00%> (ø)
....Portal/Client/Pages/Settings/DeviceTagsPage.razor 94.80% <100.00%> (+9.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efb46db...543df9d. Read the comment docs.

@hocinehacherouf hocinehacherouf changed the title Disable the edition of existing tags names #1002 Disable the edition of existing tags names on Device Tags Settings page #1002 Aug 2, 2022
@hocinehacherouf hocinehacherouf marked this pull request as ready for review August 2, 2022 15:20
@hocinehacherouf hocinehacherouf requested a review from a team as a code owner August 2, 2022 15:20
@kbeaugrand kbeaugrand merged commit ae68025 into main Aug 2, 2022
@kbeaugrand kbeaugrand deleted the bugfix/1002_fix_update_tags_by_name branch August 2, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: changing the tag name creates a new tag
2 participants