Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Edge model commands are not saved #1139

Closed
kbeaugrand opened this issue Aug 29, 2022 · 0 comments · Fixed by #1148
Closed

Bug: Edge model commands are not saved #1139

kbeaugrand opened this issue Aug 29, 2022 · 0 comments · Fixed by #1148
Assignees
@JeremyTremblay2
Labels
bug Something isn't working
Milestone
S38

Comments

@kbeaugrand
Copy link
Member

kbeaugrand commented Aug 29, 2022 •
edited
Loading

Expected Behavior

When defining commands in the edge model modules, these commands should be recoverable once getting back to the model.

Current Behavior

The module commands are not saved.

Steps to Reproduce

  1. Create an edge model
  2. Add a fake module
  3. Create a command for the module
  4. Save the module and the edge model
  5. Refresh your page
  6. Go in the module details

Context (Environment)

Portal version: 2.10
LoRaWAN Stack version: N/A

Logs

Additional Information
@kbeaugrand kbeaugrand added the bug Something isn't working label Aug 29, 2022
@kbeaugrand kbeaugrand added this to the S38 milestone Aug 29, 2022
@kbeaugrand kbeaugrand moved this to :pencil: Todo in IoT Hub Portal Aug 30, 2022
JeremyTremblay2 pushed a commit that referenced this issue Aug 30, 2022
Fix unsaved commands in the edge module #1139
dabb327
JeremyTremblay2 pushed a commit that referenced this issue Aug 30, 2022
Fix the problem of the command deletion #1139
c3195a8
@kbeaugrand kbeaugrand moved this from :pencil: Todo to :construction: In Progress in IoT Hub Portal Aug 31, 2022
JeremyTremblay2 pushed a commit that referenced this issue Aug 31, 2022
Fix save and cancel buttons in the command page #1139
5a91ec4
JeremyTremblay2 pushed a commit that referenced this issue Aug 31, 2022
Fix unit tests #1139
80b08c1
JeremyTremblay2 pushed a commit that referenced this issue Sep 1, 2022
Add unit tests for the save commands method #1139
9d78bc7
JeremyTremblay2 pushed a commit that referenced this issue Sep 1, 2022
Fix unsaved commands in the edge module #1139
7febdd8
JeremyTremblay2 pushed a commit that referenced this issue Sep 1, 2022
Fix the problem of the command deletion #1139
e6c8663
JeremyTremblay2 pushed a commit that referenced this issue Sep 1, 2022
Fix save and cancel buttons in the command page #1139
2e1daaf
JeremyTremblay2 pushed a commit that referenced this issue Sep 1, 2022
Fix unit tests #1139
ea7bb58
JeremyTremblay2 pushed a commit that referenced this issue Sep 1, 2022
Add unit tests for the save commands method #1139
13c6163
@JeremyTremblay2 JeremyTremblay2 mentioned this issue Sep 1, 2022
Merged
2 tasks
JeremyTremblay2 pushed a commit that referenced this issue Sep 1, 2022
Add unit test for the GetEdgeModuleCommands #1139
31f2d9b
JeremyTremblay2 pushed a commit that referenced this issue Sep 1, 2022
Fix cancel handle #1139
b26a861
JeremyTremblay2 added a commit that referenced this issue Sep 1, 2022
@JeremyTremblay2
Fix/1140 edge model commands not saved (#1148)
446f931 
* Fix unsaved commands in the edge module #1139

* Fix the problem of the command deletion #1139

* Fix save and cancel buttons in the command page #1139

* Fix unit tests #1139

* Add unit tests for the save commands method #1139

* Fix unsaved commands in the edge module #1139

* Fix the problem of the command deletion #1139

* Fix save and cancel buttons in the command page #1139

* Fix unit tests #1139

* Add unit tests for the save commands method #1139

* Add unit test for the GetEdgeModuleCommands #1139

* Fix cancel handle #1139

Co-authored-by: Jérémy TREMBLAY <jeremy.tremblay@cgi.com>
@kbeaugrand kbeaugrand moved this from :construction: In Progress to :rocket: Ready in IoT Hub Portal Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeremyTremblay2 JeremyTremblay2

Labels
bug Something isn't working
Projects
IoT Hub Portal
Status: 🚀 Ready
Milestone
S38
Development

Successfully merging a pull request may close this issue.

Fix/1140 edge model commands not saved CGI-FR/IoT-Hub-Portal
2 participants
@kbeaugrand @JeremyTremblay2