Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1140 edge model commands not saved #1148

Merged
merged 13 commits into from
Sep 1, 2022

Conversation

JeremyTremblay2
Copy link
Contributor

@JeremyTremblay2 JeremyTremblay2 commented Sep 1, 2022

Description

What's new?

-Fix #1139

What kind of change does this PR introduce?

  • Bugfix
  • Tests

@JeremyTremblay2 JeremyTremblay2 requested a review from a team as a code owner September 1, 2022 12:17
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Base: 86.13% // Head: 86.15% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (b26a861) compared to base (6227ce0).
Patch coverage: 88.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1148      +/-   ##
==========================================
+ Coverage   86.13%   86.15%   +0.02%     
==========================================
  Files         198      199       +1     
  Lines        6665     6712      +47     
==========================================
+ Hits         5741     5783      +42     
- Misses        924      929       +5     
Impacted Files Coverage Δ
...ent/Pages/EdgeModels/EdgeModule/ModuleDialog.razor 100.00% <ø> (ø)
...THub.Portal/Server/Factories/TableClientFactory.cs 44.44% <66.66%> (+2.02%) ⬆️
...ureIoTHub.Portal/Server/Mappers/EdgeModelMapper.cs 95.34% <84.61%> (-4.66%) ⬇️
...eIoTHub.Portal/Server/Services/EdgeModelService.cs 97.67% <90.90%> (-1.62%) ⬇️
...IoTHub.Portal/Server/Entities/EdgeModuleCommand.cs 100.00% <100.00%> (ø)
...c/AzureIoTHub.Portal/Server/Entities/EntityBase.cs 75.00% <0.00%> (+25.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

It.Is<EdgeModuleCommand>(x => x.RowKey == "Test-Command" && x.PartitionKey == iotEdgeModel.ModelId),
It.IsAny<TableUpdateMode>(),
It.IsAny<CancellationToken>()))
.Returns((Response)null);

Check warning

Code scanning / CodeQL

Useless upcast

There is no need to upcast from [null](1) to [Response](2) - the conversion can be done implicitly.
@kbeaugrand kbeaugrand self-requested a review September 1, 2022 13:35
@JeremyTremblay2 JeremyTremblay2 merged commit 446f931 into main Sep 1, 2022
@JeremyTremblay2 JeremyTremblay2 deleted the fix/1140_edge_model_commands_not_saved branch September 1, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Edge model commands are not saved
2 participants