Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Handle container create options to edge modules in edge models #1170

Closed
kbeaugrand opened this issue Sep 8, 2022 · 2 comments · Fixed by #1360
Closed

Feature: Handle container create options to edge modules in edge models #1170

kbeaugrand opened this issue Sep 8, 2022 · 2 comments · Fixed by #1360
Assignees
@hocinehacherouf
Labels
enhancement New feature or request
Milestone
S43

Comments

@kbeaugrand
Copy link
Member

Is your feature request related to a problem? Please describe.
When creating edge models, modifying an edge module should handle also the container create options.

Describe the solution you'd like
Add the container create options to the module edition popup

Describe alternatives you've considered
N/A

Additional context
N/A
@kbeaugrand kbeaugrand added enhancement New feature or request refinement labels Sep 8, 2022
@hocinehacherouf
Copy link
Contributor

Should be added as a text field below module name (on module detail)

@hocinehacherouf hocinehacherouf moved this to 📝 Todo in IoT Hub Portal Oct 10, 2022
@hocinehacherouf hocinehacherouf added this to the S42 milestone Oct 10, 2022
@hocinehacherouf hocinehacherouf moved this from 📝 Todo to 🚧 In Progress in IoT Hub Portal Oct 13, 2022
@hocinehacherouf hocinehacherouf self-assigned this Oct 13, 2022
@hocinehacherouf hocinehacherouf modified the milestones: S42, S43 Oct 14, 2022
@hocinehacherouf hocinehacherouf mentioned this issue Oct 16, 2022
Closed
9 tasks
hocinehacherouf added a commit that referenced this issue Oct 16, 2022
@hocinehacherouf
Add container create options on create/edit edge module #1170
0507519
@hocinehacherouf
Copy link
Contributor

A text field for Container Create Options is available on the edge module dialog + An info field containing an url about How to configure container create options for IoT Edge modules:

image

@hocinehacherouf hocinehacherouf moved this from 🚧 In Progress to 💬 Ready for Review in IoT Hub Portal Oct 16, 2022
kbeaugrand pushed a commit that referenced this issue Oct 16, 2022
@hocinehacherouf @kbeaugrand
Update unit test GenerateModulesContentShouldReturnValue
578eda5 
Update unit tests on ConfigHelper

Add info link on how to configure a container create options

Add container create options on create/edit edge module #1170
@kbeaugrand kbeaugrand mentioned this issue Oct 16, 2022
Merged
9 tasks
kbeaugrand added a commit that referenced this issue Oct 16, 2022
@kbeaugrand @hocinehacherouf
Update unit test GenerateModulesContentShouldReturnValue (#1360)
de5ef92 
Update unit tests on ConfigHelper

Add info link on how to configure a container create options

Add container create options on create/edit edge module #1170

Co-authored-by: Hocine Hacherouf <hacherouf.hocine@gmail.com>
@github-actions github-actions bot mentioned this issue Oct 16, 2022
Merged
@hocinehacherouf hocinehacherouf moved this from 💬 Ready for Review to 🚀 Ready in IoT Hub Portal Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hocinehacherouf hocinehacherouf

Labels
enhancement New feature or request
Projects
IoT Hub Portal
Status: 🚀 Ready
Milestone
S43
2 participants
@kbeaugrand @hocinehacherouf