Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container create options on create/edit edge module #1170 #1360

Merged
merged 1 commit into from
Oct 16, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Oct 16, 2022

Description

Fix #1170

What's new?

  • Update unit tests on ConfigHelper
  • Add info link on how to configure a container create options
  • Update unit test GenerateModulesContentShouldReturnValue

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Update unit tests on ConfigHelper

Add info link on how to configure a container create options

Add container create options on create/edit edge module #1170
@kbeaugrand kbeaugrand marked this pull request as ready for review October 16, 2022 17:06
@kbeaugrand kbeaugrand requested a review from a team as a code owner October 16, 2022 17:06
@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Base: 88.99% // Head: 89.00% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (578eda5) compared to base (18aaf95).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1360   +/-   ##
=======================================
  Coverage   88.99%   89.00%           
=======================================
  Files         250      250           
  Lines        7726     7731    +5     
=======================================
+ Hits         6876     6881    +5     
  Misses        850      850           
Impacted Files Coverage Δ
...ent/Pages/EdgeModels/EdgeModule/ModuleDialog.razor 100.00% <100.00%> (ø)
.../AzureIoTHub.Portal/Server/Helpers/ConfigHelper.cs 85.71% <100.00%> (+0.14%) ⬆️
...eIoTHub.Portal/Shared/Models/v1.0/IoTEdgeModule.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand merged commit de5ef92 into main Oct 16, 2022
@kbeaugrand kbeaugrand deleted the feature/1170_container_create_options branch October 16, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Handle container create options to edge modules in edge models
2 participants