Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: When not specifying a concentrator thumbprint, empty string is added in twin #1409

Closed
kbeaugrand opened this issue Oct 25, 2022 · 2 comments · Fixed by #1470
Closed

Bug: When not specifying a concentrator thumbprint, empty string is added in twin #1409

kbeaugrand opened this issue Oct 25, 2022 · 2 comments · Fixed by #1470
Assignees
@kbeaugrand
Labels
bug Something isn't working
Milestone
S44

Comments

@kbeaugrand
Copy link
Member

Expected Behavior

When I add a new concentrator without any client thumbprint, the device twin should not have any thumbprint set.

Current Behavior

The device twin have a thumbprint with empty string:

image

Steps to Reproduce

  1. Create a new concentrator
  2. Do not set any thumbprint
  3. Save the concentrator

Context (Environment)

Portal version: 3.3.0
LoRaWAN Stack version: N/A

Logs

Additional Information
@kbeaugrand kbeaugrand added the bug Something isn't working label Oct 25, 2022
@kbeaugrand kbeaugrand added this to the S44 milestone Oct 25, 2022
@kbeaugrand kbeaugrand moved this to 📝 Todo in IoT Hub Portal Oct 25, 2022
@kbeaugrand
Copy link
Member Author

Additional information:
When not specifying, the clientThumbprints in the device model should not be present at all.

@audserraCGI
Copy link
Contributor

The field should also be updated in the database:

Npgsql.PostgresException (0x80004005): 23502: null value in column "ClientThumbprint" of relation "Concentrators" violates not-null constraint

@kbeaugrand kbeaugrand self-assigned this Oct 28, 2022
@kbeaugrand kbeaugrand moved this from 📝 Todo to 🚧 In Progress in IoT Hub Portal Oct 28, 2022
@kbeaugrand kbeaugrand moved this from 🚧 In Progress to 💬 Ready for Review in IoT Hub Portal Oct 28, 2022
@kbeaugrand kbeaugrand mentioned this issue Oct 28, 2022
Merged
9 tasks
kbeaugrand added a commit that referenced this issue Oct 28, 2022
@kbeaugrand
Fix #1409 - Client thubmpring should not be present in device twin if…
4b27599 
… empty
kbeaugrand added a commit that referenced this issue Oct 28, 2022
@kbeaugrand
Fix #1409 - Client thubmpring should not be present in device twin if…
3541eea 
… empty (#1470)
@kbeaugrand kbeaugrand moved this from 💬 Ready for Review to 🚀 Ready in IoT Hub Portal Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kbeaugrand kbeaugrand

Labels
bug Something isn't working
Projects
IoT Hub Portal
Status: 🚀 Ready
Milestone
S44
Development

Successfully merging a pull request may close this issue.

Fix #1409 - Client thumbprint should not be present in device twin if… CGI-FR/IoT-Hub-Portal
2 participants
@kbeaugrand @audserraCGI