Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1409 - Client thumbprint should not be present in device twin if… #1470

Merged

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Oct 28, 2022

… empty

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand marked this pull request as ready for review October 28, 2022 09:05
@kbeaugrand kbeaugrand requested a review from a team as a code owner October 28, 2022 09:05
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 89.59% // Head: 89.59% // No change to project coverage 👍

Coverage data is based on head (4d902da) compared to base (4d902da).
Patch has no changes to coverable lines.

❗ Current head 4d902da differs from pull request most recent head 4b27599. Consider uploading reports for the commit 4b27599 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1470   +/-   ##
=======================================
  Coverage   89.59%   89.59%           
=======================================
  Files         256      256           
  Lines        8064     8064           
=======================================
  Hits         7225     7225           
  Misses        839      839           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand force-pushed the fix/1409_chlientThumbprint_should_be_null_when_not_provided branch from 93cb8ab to 5f39a61 Compare October 28, 2022 09:14
@kbeaugrand kbeaugrand force-pushed the fix/1409_chlientThumbprint_should_be_null_when_not_provided branch from 5f39a61 to 4b27599 Compare October 28, 2022 09:25
@kbeaugrand kbeaugrand merged commit 3541eea into main Oct 28, 2022
@kbeaugrand kbeaugrand deleted the fix/1409_chlientThumbprint_should_be_null_when_not_provided branch October 28, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: When not specifying a concentrator thumbprint, empty string is added in twin
1 participant