Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Change portal deployment to next major instead of latest #1583

Closed
kbeaugrand opened this issue Nov 23, 2022 · 1 comment · Fixed by #1639
Closed

Feature: Change portal deployment to next major instead of latest #1583

kbeaugrand opened this issue Nov 23, 2022 · 1 comment · Fixed by #1639
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@kbeaugrand
Copy link
Member

Is your feature request related to a problem? Please describe.
Our templates are deploying the latest version of the portal.

Describe the solution you'd like
Change the docker tag to point to the next major version that should be deployed.

Describe alternatives you've considered
N/A

Additional context
Investigate to automatically point the the major version from the CI.

@kbeaugrand kbeaugrand added enhancement New feature or request refinement labels Nov 23, 2022
@developer-companion developer-companion bot moved this to 📝 Todo in IoT Hub Portal Nov 23, 2022
@kbeaugrand
Copy link
Member Author

kbeaugrand commented Nov 23, 2022

We might use sed to replace the image tag uri from the bicep files:
's/ghcr.io\/cgi-fr\/iothub-portal:latest/ghcr.io\/cgi-fr\/iothub-portal:3/'

The sed command will be used at

sed -r -i 's/..\/iotedge-lorawan-starterkit\/TemplateBicep\/main.bicep/.\/iotedge-lorawan-starterkit\/main.bicep/g' ./templates/azuredeploy.bicep

The version should not be hard coded, it should be taken from the release pipeline (the current tag of the release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 🚀 Ready
Development

Successfully merging a pull request may close this issue.

2 participants