Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override IoTHub Portal docker image tag on bicep template on release #1639

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

hocinehacherouf
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@hocinehacherouf hocinehacherouf marked this pull request as ready for review December 5, 2022 14:48
@hocinehacherouf hocinehacherouf requested a review from a team as a code owner December 5, 2022 14:48
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 90.04% // Head: 90.09% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (27c2fad) compared to base (b210968).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1639      +/-   ##
==========================================
+ Coverage   90.04%   90.09%   +0.04%     
==========================================
  Files         268      268              
  Lines        8834     8838       +4     
==========================================
+ Hits         7955     7963       +8     
+ Misses        879      875       -4     
Impacted Files Coverage Δ
...c/AzureIoTHub.Portal.Server/Jobs/SyncDevicesJob.cs 97.14% <100.00%> (+4.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hocinehacherouf hocinehacherouf merged commit 7ae6749 into main Dec 5, 2022
@hocinehacherouf hocinehacherouf deleted the Feature/1583_overid_portal_image_tag_deploy branch December 5, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Change portal deployment to next major instead of latest
2 participants