Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Standardize loading screens #848

Closed
audserraCGI opened this issue Jun 23, 2022 · 1 comment · Fixed by #916
Closed

Feature: Standardize loading screens #848

audserraCGI opened this issue Jun 23, 2022 · 1 comment · Fixed by #916
Assignees
@hocinehacherouf
Labels
enhancement New feature or request
Milestone
S32

Comments

@audserraCGI
Copy link
Contributor

When opening a page, I expect the loading animations to be the same on every page.

Currently, loading animations are inconsistent on various pages (at least 3 different behaviours):

  • Device Detail: No animation, fields are filled after the data is loaded
  • Device Model Detail: Round loading indicator on the top left, the page only appears after the data is loaded
  • Device Configuration: Loading animation on the top of the page, fields are filled after the data is loaded
@audserraCGI audserraCGI added enhancement New feature or request refinement labels Jun 23, 2022
@kbeaugrand kbeaugrand changed the title Feature: Standardise loading screens Feature: Standardize loading screens Jun 23, 2022
@kbeaugrand
Copy link
Member

Saw in PBR. The solution should :

  • use Loading bar on the top of the page
  • disable the buttons during the loading
  • not change the page height when not loading

List screen not changed.

@kbeaugrand kbeaugrand modified the milestones: S30, S31 Jul 1, 2022
@kbeaugrand kbeaugrand moved this to :pencil: Todo in IoT Hub Portal Jul 1, 2022
@hocinehacherouf hocinehacherouf moved this from :pencil: Todo to :construction: In Progress in IoT Hub Portal Jul 3, 2022
@hocinehacherouf hocinehacherouf mentioned this issue Jul 3, 2022
Closed
@hocinehacherouf hocinehacherouf moved this from :construction: In Progress to :pencil: Todo in IoT Hub Portal Jul 7, 2022
@hocinehacherouf hocinehacherouf modified the milestones: S31, S32 Jul 11, 2022
@hocinehacherouf hocinehacherouf moved this from :pencil: Todo to :construction: In Progress in IoT Hub Portal Jul 11, 2022
hocinehacherouf added a commit that referenced this issue Jul 11, 2022
@hocinehacherouf
Remove loading animation on Device.ConnectionStringDialog #848
715a444
hocinehacherouf added a commit that referenced this issue Jul 11, 2022
@hocinehacherouf
Disable button on processing + remove loading anim on DeviceDetails #848
196b504
hocinehacherouf added a commit that referenced this issue Jul 11, 2022
@hocinehacherouf
Disable send command button on processing #848
f122fd1
hocinehacherouf added a commit that referenced this issue Jul 11, 2022
@hocinehacherouf
Disable save button on save device #848
1458060
hocinehacherouf added a commit that referenced this issue Jul 11, 2022
@hocinehacherouf
Disable save button on save tags #848
f51db88
@hocinehacherouf hocinehacherouf mentioned this issue Jul 11, 2022
Merged
9 tasks
hocinehacherouf added a commit that referenced this issue Jul 11, 2022
@hocinehacherouf
Disable save button on create device config #848
0e3f6af
hocinehacherouf added a commit that referenced this issue Jul 11, 2022
@hocinehacherouf
Disable save and delete buttons on device config details #848
c08b916
hocinehacherouf added a commit that referenced this issue Jul 11, 2022
@hocinehacherouf
Disable save and delete buttons on edge device details #848
d06058d
hocinehacherouf added a commit that referenced this issue Jul 11, 2022
@hocinehacherouf
Remove loading animation on edge Device ConnectionStringDialog #848
61b8f8f
hocinehacherouf added a commit that referenced this issue Jul 11, 2022
@hocinehacherouf
Remove loading animation on DeviceModelListPage #848
1411c58
hocinehacherouf added a commit that referenced this issue Jul 11, 2022
@hocinehacherouf
Disable save button on create device model #848
0980bb8
hocinehacherouf added a commit that referenced this issue Jul 11, 2022
@hocinehacherouf
Disable save and delete buttons on device model details #848
c1b606b
hocinehacherouf added a commit that referenced this issue Jul 11, 2022
@hocinehacherouf
Disable save button on create concentrator #848
83382be
hocinehacherouf added a commit that referenced this issue Jul 11, 2022
@hocinehacherouf
Disable save and delete buttons on concentrator details #848
168c409
hocinehacherouf added a commit that referenced this issue Jul 12, 2022
@hocinehacherouf
Disable save button on load concentrator details #848
bf34d1a
@hocinehacherouf hocinehacherouf moved this from :construction: In Progress to :speech_balloon: Ready for Review in IoT Hub Portal Jul 12, 2022
hocinehacherouf added a commit that referenced this issue Jul 13, 2022
@hocinehacherouf
Standardize loading screens #848 (#916)
8391717 
* Remove loading animation on Device.ConnectionStringDialog #848

* Disable button on processing + remove loading anim on DeviceDetails #848

* Disable send command button on processing #848

* Disable save button on save device #848

* Disable save button on save tags #848

* Disable save button on create device config #848

* Disable save and delete buttons on device config details #848

* Disable save and delete buttons on edge device details #848

* Remove loading animation on edge Device ConnectionStringDialog #848

* Remove loading animation on DeviceModelListPage #848

* Disable save button on create device model #848

* Disable save and delete buttons on device model details #848

* Disable save button on create concentrator #848

* Disable save and delete buttons on concentrator details #848

* Delete unused processing dialog

* Disable save button on load concentrator details #848

* Add unit test DeviceShouldNotBeCreatedWhenModelIsNotValid


Add unit test DeviceShouldNotBeCreatedWhenModelIsNotValid

* Add unit test ConcentratorShouldNotBeUpdatedWhenModelIsNotValid

* Add unit test ClickOnDeleteDeviceConfigurationShouldShowDeleteDialog
@hocinehacherouf hocinehacherouf moved this from :speech_balloon: Ready for Review to :rocket: Ready in IoT Hub Portal Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hocinehacherouf hocinehacherouf

Labels
enhancement New feature or request
Projects
IoT Hub Portal
Status: 🚀 Ready
Milestone
S32
Development

Successfully merging a pull request may close this issue.

Standardize loading screens #848 CGI-FR/IoT-Hub-Portal
3 participants
@kbeaugrand @hocinehacherouf @audserraCGI