Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize loading screens #848 #916

Merged
merged 19 commits into from
Jul 13, 2022

Conversation

hocinehacherouf
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #916 (0ddc9a6) into main (df9c395) will increase coverage by 0.48%.
The diff coverage is 85.60%.

@@            Coverage Diff             @@
##             main     #916      +/-   ##
==========================================
+ Coverage   83.35%   83.84%   +0.48%     
==========================================
  Files         168      167       -1     
  Lines        5581     5552      -29     
==========================================
+ Hits         4652     4655       +3     
+ Misses        929      897      -32     
Impacted Files Coverage Δ
.../Client/Pages/Devices/LoRaWAN/EditLoraDevice.razor 0.00% <0.00%> (ø)
...ent/Pages/EdgeDevices/ConnectionStringDialog.razor 78.94% <0.00%> (+0.37%) ⬆️
.../Client/Pages/Devices/ConnectionStringDialog.razor 75.00% <33.33%> (+1.92%) ⬆️
.../LoRaWAN/Concentrator/ConcentratorDetailPage.razor 79.36% <70.00%> (+6.48%) ⬆️
...lient/Pages/DeviceModels/DeviceModelListPage.razor 97.43% <80.00%> (+4.25%) ⬆️
...ent/Pages/DeviceModels/CreateDeviceModelPage.razor 66.22% <83.33%> (ø)
...lient/Pages/EdgeDevices/EdgeDeviceDetailPage.razor 90.81% <85.71%> (+1.49%) ⬆️
...onfigurations/CreateDeviceConfigurationsPage.razor 53.46% <100.00%> (+1.50%) ⬆️
...Configurations/DeviceConfigurationDetailPage.razor 88.11% <100.00%> (+11.58%) ⬆️
...ent/Pages/DeviceModels/DeviceModelDetailPage.razor 73.50% <100.00%> (+1.50%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df9c395...0ddc9a6. Read the comment docs.

@hocinehacherouf hocinehacherouf marked this pull request as ready for review July 12, 2022 18:20
@hocinehacherouf hocinehacherouf requested a review from a team as a code owner July 12, 2022 18:20
@hocinehacherouf hocinehacherouf enabled auto-merge (squash) July 12, 2022 18:21
@hocinehacherouf hocinehacherouf merged commit 8391717 into main Jul 13, 2022
@hocinehacherouf hocinehacherouf deleted the feature/848_rework_loading_screens branch July 13, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Standardize loading screens
2 participants