Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task 988/Refactor EdgeDevicesController #1113

Merged
merged 11 commits into from
Aug 23, 2022

Conversation

Sben65
Copy link
Contributor

@Sben65 Sben65 commented Aug 22, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@Sben65 Sben65 requested a review from a team as a code owner August 22, 2022 14:55
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Base: 85.93% // Head: 85.99% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (adee709) compared to base (91e4499).
Patch coverage: 93.02% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1113      +/-   ##
==========================================
+ Coverage   85.93%   85.99%   +0.05%     
==========================================
  Files         194      196       +2     
  Lines        6471     6491      +20     
==========================================
+ Hits         5561     5582      +21     
+ Misses        910      909       -1     
Impacted Files Coverage Δ
...ureIoTHub.Portal/Server/Mappers/EdgeModelMapper.cs 100.00% <ø> (ø)
...eIoTHub.Portal/Server/Services/EdgeModelService.cs 99.28% <ø> (ø)
...eIoTHub.Portal/Shared/Models/v1.0/IoTEdgeModule.cs 100.00% <ø> (ø)
...oTHub.Portal/Server/Services/EdgeDevicesService.cs 89.83% <89.83%> (ø)
...lient/Pages/EdgeDevices/EdgeDeviceDetailPage.razor 90.81% <100.00%> (ø)
...ortal/Server/Controllers/v1.0/DevicesController.cs 93.81% <100.00%> (ø)
...l/Server/Controllers/v1.0/DevicesControllerBase.cs 97.65% <100.00%> (ø)
...l/Server/Controllers/v1.0/EdgeDevicesController.cs 100.00% <100.00%> (+7.47%) ⬆️
...ers/v1.0/LoRaWAN/LoRaWANConcentratorsController.cs 90.12% <100.00%> (ø)
...reIoTHub.Portal/Server/Mappers/EdgeDeviceMapper.cs 100.00% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Sben65 Sben65 merged commit 99c10c2 into main Aug 23, 2022
@Sben65 Sben65 deleted the Task#988/Refactor_EdgeDevicesController branch August 23, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor EdgeDevicesController
2 participants