Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task 988/Refactor EdgeDevicesController #1113

Merged
merged 11 commits into from
Aug 23, 2022
Merged

Task 988/Refactor EdgeDevicesController #1113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
3878b6b
refactor edgeDeviceController logic.
Sben65 Aug 22, 2022
14b5cd4
add new unit test for EdgeDeviceService
Sben65 Aug 22, 2022
9a66758
fix unit test
Sben65 Aug 22, 2022
764b260
new test edgeDeviceController
Sben65 Aug 22, 2022
1f7b675
add new test on edgeDeviceMapper
Sben65 Aug 23, 2022
7fd7888
add new test for edge device controller
Sben65 Aug 23, 2022
b92bba8
fix code scanning issue
Sben65 Aug 23, 2022
3850374
fix code scanning alert
Sben65 Aug 23, 2022
37d0cb1
resolve code scanning issue
Sben65 Aug 23, 2022
73bb761
fix code scanning issue
Sben65 Aug 23, 2022
adee709
fix code scanning error
Sben65 Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/AzureIoTHub.Portal.Tests.Unit/Client/Pages/EdgeModels/CreateEdgeModelsPageTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ public void WhenModulesRequiredFieldEmptyClickOnSaveShouldProssessValidationErro

_ = this.mockSnackbarService
.Setup(c => c.Add(It.IsAny<string>(), Severity.Error, It.IsAny<Action<SnackbarOptions>>()))
.Returns((Snackbar)null);
.Returns(value: null);

// Act
var cut = RenderComponent<CreateEdgeModelsPage>();
Expand Down
5 changes: 1 addition & 4 deletions src/AzureIoTHub.Portal.Tests.Unit/Server/Controllers/v1.0/DevicesControllerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ public async Task UpdateDeviceAsyncStateUnderTestExpectedBehavior()
.ReturnsAsync(twin);
_ = this.mockDeviceService.Setup(c => c.UpdateDevice(It.Is<Device>(x => x.Id == item.Id)))
.ReturnsAsync(item);
_ = this.mockDeviceService.Setup(c => c.UpdateDeviceTwin(It.Is<string>(x => x == device.DeviceID), It.Is<Twin>(x => x.DeviceId == device.DeviceID)))
_ = this.mockDeviceService.Setup(c => c.UpdateDeviceTwin(It.Is<Twin>(x => x.DeviceId == device.DeviceID)))
.ReturnsAsync(twin);

_ = this.mockDeviceTwinMapper.Setup(x => x.UpdateTwin(It.Is<Twin>(x => x == twin), It.Is<DeviceDetails>(x => x == device)));
Expand Down Expand Up @@ -580,7 +580,6 @@ public async Task SetPropertiesShouldUpdateDesiredProperties()
.ReturnsAsync(twin);

_ = this.mockDeviceService.Setup(c => c.UpdateDeviceTwin(
It.Is<string>(c => c == "aaa"),
It.Is<Twin>(c => c == twin)))
.ReturnsAsync(twin);

Expand Down Expand Up @@ -680,7 +679,6 @@ public async Task WhenPropertyNotWrittableSetPropertiesShouldNotUpdateDesiredPro
.ReturnsAsync(twin);

_ = this.mockDeviceService.Setup(c => c.UpdateDeviceTwin(
It.Is<string>(c => c == "aaa"),
It.Is<Twin>(c => c == twin)))
.ReturnsAsync(twin);

Expand Down Expand Up @@ -741,7 +739,6 @@ public async Task WhenPropertyNotInModelSetPropertiesShouldNotUpdateDesiredPrope
.ReturnsAsync(twin);

_ = this.mockDeviceService.Setup(c => c.UpdateDeviceTwin(
It.Is<string>(c => c == "aaa"),
It.Is<Twin>(c => c == twin)))
.ReturnsAsync(twin);

Expand Down
Loading