Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/1317 edge device connection state should be stored on database #1464

Conversation

ChristopheRib63
Copy link
Contributor

@ChristopheRib63 ChristopheRib63 commented Oct 27, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand force-pushed the main branch 5 times, most recently from 8949e49 to bf921a1 Compare October 27, 2022 20:55
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Base: 89.60% // Head: 89.60% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (088effc) compared to base (3541eea).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1464   +/-   ##
=======================================
  Coverage   89.60%   89.60%           
=======================================
  Files         256      256           
  Lines        8070     8073    +3     
=======================================
+ Hits         7231     7234    +3     
  Misses        839      839           
Impacted Files Coverage Δ
...oTHub.Portal.Server/Services/EdgeDevicesService.cs 96.13% <ø> (-0.03%) ⬇️
...c/AzureIoTHub.Portal.Domain/Entities/EdgeDevice.cs 100.00% <100.00%> (ø)
...eIoTHub.Portal.Server/Mappers/EdgeDeviceProfile.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChristopheRib63 ChristopheRib63 marked this pull request as ready for review October 28, 2022 09:27
@ChristopheRib63 ChristopheRib63 requested a review from a team as a code owner October 28, 2022 09:27
@kbeaugrand kbeaugrand force-pushed the Task/1317_Edge_device_connection_state_should_be_stored_on_database branch from 042e60e to 088effc Compare October 28, 2022 09:53
@kbeaugrand kbeaugrand enabled auto-merge (squash) October 28, 2022 09:54
@kbeaugrand kbeaugrand merged commit bf8c873 into main Oct 28, 2022
@kbeaugrand kbeaugrand deleted the Task/1317_Edge_device_connection_state_should_be_stored_on_database branch October 28, 2022 10:07
kbeaugrand added a commit that referenced this pull request Oct 28, 2022
kbeaugrand added a commit that referenced this pull request Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Edge device connection state should be stored on database
2 participants