Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1317 - Add connection state to local storage #1484

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Fix #1317 - Add connection state to local storage #1484

merged 1 commit into from
Nov 2, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Oct 28, 2022 •
edited
Loading

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand force-pushed the feature/1317_store_edge_device_connection_state_to_local_database branch from c38e5ae to b91ca86 Compare October 28, 2022 15:46
@kbeaugrand kbeaugrand marked this pull request as ready for review October 28, 2022 15:46
@kbeaugrand kbeaugrand requested a review from a team as a code owner October 28, 2022 15:46
@codecov
Copy link

codecov bot commented Oct 28, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@b7d2514). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 1bdc446 differs from pull request most recent head ac56744. Consider uploading reports for the commit ac56744 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1484   +/-   ##
=======================================
  Coverage        ?   89.54%           
=======================================
  Files           ?      255           
  Lines           ?     8034           
  Branches        ?        0           
=======================================
  Hits            ?     7194           
  Misses          ?      840           
  Partials        ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kbeaugrand kbeaugrand force-pushed the feature/1317_store_edge_device_connection_state_to_local_database branch 2 times, most recently from e0ce328 to 7153ea0 Compare October 31, 2022 07:25
@kbeaugrand kbeaugrand force-pushed the feature/1317_store_edge_device_connection_state_to_local_database branch from 7153ea0 to ac56744 Compare November 1, 2022 18:12
@kbeaugrand kbeaugrand force-pushed the feature/1317_store_edge_device_connection_state_to_local_database branch from ac56744 to 129c3a2 Compare November 2, 2022 15:17
@kbeaugrand kbeaugrand enabled auto-merge (squash) November 2, 2022 15:17
@kbeaugrand kbeaugrand force-pushed the feature/1317_store_edge_device_connection_state_to_local_database branch from 129c3a2 to 1106b9e Compare November 2, 2022 17:50
@kbeaugrand kbeaugrand merged commit 752cff3 into main Nov 2, 2022
@kbeaugrand kbeaugrand deleted the feature/1317_store_edge_device_connection_state_to_local_database branch November 2, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sben65 Sben65 Sben65 approved these changes

@hocinehacherouf hocinehacherouf hocinehacherouf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task: Edge device connection state should be stored on database
3 participants
@kbeaugrand @hocinehacherouf @Sben65