Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1242 filter devices by device model #1511

Merged
merged 3 commits into from
Nov 11, 2022

Conversation

ChristopheRib63
Copy link
Contributor

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 89.95% // Head: 89.73% // Decreases project coverage by -0.22% ⚠️

Coverage data is based on head (116d3dd) compared to base (040eefe).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1511      +/-   ##
==========================================
- Coverage   89.95%   89.73%   -0.23%     
==========================================
  Files         256      256              
  Lines        7995     8034      +39     
==========================================
+ Hits         7192     7209      +17     
- Misses        803      825      +22     
Impacted Files Coverage Δ
...IoTHub.Portal.Server/Services/DeviceServiceBase.cs 96.06% <42.85%> (-3.12%) ⬇️
...b.Portal.Client/Pages/Devices/DeviceListPage.razor 60.93% <43.75%> (-6.08%) ⬇️
...ortal.Server/Controllers/v1.0/DevicesController.cs 100.00% <100.00%> (ø)
...l.Server/Controllers/v1.0/DevicesControllerBase.cs 98.83% <100.00%> (+0.01%) ⬆️
...ntrollers/v1.0/LoRaWAN/LoRaWANDevicesController.cs 100.00% <100.00%> (ø)
...tal.Shared/Models/v1.0/Filters/DeviceListFilter.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ChristopheRib63 ChristopheRib63 marked this pull request as ready for review November 10, 2022 10:50
@ChristopheRib63 ChristopheRib63 requested a review from a team as a code owner November 10, 2022 10:50
@kbeaugrand kbeaugrand force-pushed the Fix/1242_Filter_devices_by_device_model branch from 9e3f0bc to 116d3dd Compare November 11, 2022 09:30
@kbeaugrand kbeaugrand enabled auto-merge (squash) November 11, 2022 09:31
@kbeaugrand kbeaugrand disabled auto-merge November 11, 2022 11:47
@kbeaugrand kbeaugrand merged commit 3e769e1 into main Nov 11, 2022
@kbeaugrand kbeaugrand deleted the Fix/1242_Filter_devices_by_device_model branch November 11, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Filter devices by device model
2 participants