Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1597 - Move Get Telemetry to LoRaWAN device controller only #1598

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Nov 25, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand marked this pull request as ready for review November 25, 2022 06:22
@kbeaugrand kbeaugrand requested a review from a team as a code owner November 25, 2022 06:22
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 89.73% // Head: 89.73% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (894c880) compared to base (f700d62).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1598   +/-   ##
=======================================
  Coverage   89.73%   89.73%           
=======================================
  Files         265      265           
  Lines        8395     8396    +1     
=======================================
+ Hits         7533     7534    +1     
  Misses        862      862           
Impacted Files Coverage Δ
...l.Server/Controllers/v1.0/DevicesControllerBase.cs 98.83% <ø> (-0.04%) ⬇️
...ntrollers/v1.0/LoRaWAN/LoRaWANDevicesController.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hocinehacherouf hocinehacherouf merged commit b130300 into main Nov 25, 2022
@hocinehacherouf hocinehacherouf deleted the f1597/get_telemetry_only_on_lorawan branch November 25, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: API should not have get telemetry on all devices
2 participants