Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/connection state update 2574 #2688

Merged
merged 2 commits into from
Dec 11, 2023
Merged

Conversation

TLeoDev
Copy link
Member

@TLeoDev TLeoDev commented Dec 11, 2023

Description

Fix of issue #2574

What's new?

  • The application now correctly reflects the ConnectionState of devices. When the ConnectionState in Azure IoT Hub is set to Connected, this status is accurately updated. So the 'reboot' and 'log' buttons are no enabled instead of always disabled.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@TLeoDev TLeoDev requested a review from a team as a code owner December 11, 2023 14:17
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (61c0589) 85.74% compared to head (abe6514) 85.74%.

Files Patch % Lines
...ub.Portal.Infrastructure/Jobs/SyncEdgeDeviceJob.cs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2688      +/-   ##
==========================================
- Coverage   85.74%   85.74%   -0.01%     
==========================================
  Files         296      296              
  Lines       11338    11340       +2     
  Branches      889      890       +1     
==========================================
+ Hits         9722     9723       +1     
  Misses       1325     1325              
- Partials      291      292       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kbeaugrand kbeaugrand merged commit 9d30648 into main Dec 11, 2023
7 checks passed
@kbeaugrand kbeaugrand deleted the fix/connectionStateUpdate-2574 branch December 11, 2023 15:37
@TLeoDev TLeoDev added the bug Something isn't working label Dec 11, 2023
@TLeoDev TLeoDev self-assigned this Dec 11, 2023
@TLeoDev TLeoDev added iot-edge .NET Pull requests that update .net code labels Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working iot-edge .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants