Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set global.json SDK version to first SDK release #2997

Merged
merged 4 commits into from
May 25, 2024

Conversation

Metal-Mighty
Copy link
Contributor

@Metal-Mighty Metal-Mighty commented May 24, 2024

Default behavior for global.json is to look for the latest feature band or patch version for the set SDK

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Default behavior for global.json is to look for the latest feature band or patch version for the set SDK
@Metal-Mighty Metal-Mighty requested a review from a team as a code owner May 24, 2024 07:54
@Metal-Mighty Metal-Mighty self-assigned this May 24, 2024
@Metal-Mighty Metal-Mighty enabled auto-merge (rebase) May 24, 2024 08:30
@Metal-Mighty Metal-Mighty modified the milestone: v6.0 May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.04%. Comparing base (c7b77c3) to head (ea30a3a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2997      +/-   ##
==========================================
+ Coverage   85.87%   86.04%   +0.16%     
==========================================
  Files         296      295       -1     
  Lines       11344    11331      -13     
  Branches      890      873      -17     
==========================================
+ Hits         9742     9750       +8     
+ Misses       1311     1298      -13     
+ Partials      291      283       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Metal-Mighty Metal-Mighty disabled auto-merge May 25, 2024 23:19
@Metal-Mighty Metal-Mighty enabled auto-merge (rebase) May 25, 2024 23:19
@Metal-Mighty Metal-Mighty merged commit be9f08c into main May 25, 2024
6 checks passed
@Metal-Mighty Metal-Mighty deleted the feature/2996-globaljson-versions branch May 25, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Set global.json to accept future feature band/patch versions
2 participants