Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused settings in the portal #961

Merged
merged 1 commit into from
Jul 23, 2022
Merged

Conversation

kbeaugrand
Copy link
Member

@kbeaugrand kbeaugrand commented Jul 23, 2022

Description

What's new?

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

@kbeaugrand kbeaugrand marked this pull request as ready for review July 23, 2022 16:59
@kbeaugrand kbeaugrand requested a review from a team as a code owner July 23, 2022 16:59
@kbeaugrand kbeaugrand force-pushed the fix/remove_unused_settings branch from 531002e to 9ce86bf Compare July 23, 2022 16:59
@codecov
Copy link

codecov bot commented Jul 23, 2022

Codecov Report

Merging #961 (9ce86bf) into main (2981b3d) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main     #961      +/-   ##
==========================================
- Coverage   85.90%   85.89%   -0.02%     
==========================================
  Files         173      173              
  Lines        5613     5600      -13     
==========================================
- Hits         4822     4810      -12     
+ Misses        791      790       -1     
Impacted Files Coverage Δ
src/AzureIoTHub.Portal/Server/ConfigHandler.cs 0.00% <ø> (ø)
...reIoTHub.Portal/Server/DevelopmentConfigHandler.cs 77.41% <ø> (-1.37%) ⬇️
...ureIoTHub.Portal/Server/ProductionConfigHandler.cs 77.41% <ø> (-1.37%) ⬇️
...r/ServicesHealthCheck/StorageAccountHealthCheck.cs 85.71% <75.00%> (ø)
...ver/ServicesHealthCheck/TableStorageHealthCheck.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2981b3d...9ce86bf. Read the comment docs.

@kbeaugrand kbeaugrand merged commit 48f8945 into main Jul 23, 2022
@kbeaugrand kbeaugrand deleted the fix/remove_unused_settings branch July 23, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Remove unused settings form the portal
1 participant