Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for v4.0.0 release #573

Open
wants to merge 1,606 commits into
base: master
Choose a base branch
from
Open

Prepare for v4.0.0 release #573

wants to merge 1,606 commits into from

Conversation

wknoben
Copy link
Collaborator

@wknoben wknoben commented Jul 27, 2024

Updates master with the SUNDIALS and related developments. High level changes:

  • Addition option to use SUNDIALS library to solve model equation (optional, default compilation is without SUNDIALS).
  • BMI implementation.
  • Energy state calculation now based on enthalpy.
  • CMake build files for SUMMA.
  • CMake build files for Actors model for parallelization.
  • Various bugfixes.
  • Indentation fixes.

ashleymedin added 30 commits April 9, 2024 14:51
@ashleymedin
need to recalculate enthalpy every time water changes; this makes the…
28ec2aa 
… wallClock longer-- might want to just do at beginning and end of data window
@ashleymedin
spaces
fbe59fd
@ashleymedin
start with last solution for temperature from enthalpy
aa94054
@ashleymedin
putting in Brent function instead of Newton
8f96aa8
@ashleymedin
fix inputs enthalpy
9e4b18a
@ashleymedin
send in specific canopyDepth since diag_data may have changed
03c79be
@ashleymedin
check enthalpy for consistency if ida or BE
712a0cb
@ashleymedin
snow enthalpy was incorrect
033e3ab
@ashleymedin
trigger the snow layer merge in enthalpy state vec
5978a60
@ashleymedin
remove prints
6e7eef0
@ashleymedin
add a decision for starting with empty aquifer, defaults to full if d…
777230d 
…o not set
@ashleymedin
need to change root finding to be on enthalpy
ab4d33a
@ashleymedin
remove print statement
ab34c15
@ashleymedin
need to put snow merge condition on enthalpy as well as temperature
4602138
@ashleymedin
better bounds for brent function
59ec2d8
@ashleymedin
remove print statement
8de636a
@ashleymedin
calculate snow merge detection outside of brent
45fa875
@ashleymedin
a bit more Brent speed up
e42e665
@ashleymedin
account for missing vegetation in jacobian
d16bc16
@ashleymedin
banded enthalpy Jacobian needed different index
8d69cbe
@ashleymedin
remove scaledBalance variable, decision name clarify-- now closedForm…
64969dd 
…, enthalpyFormLU, or enthalpyForm
@ashleymedin
make balance for snow realMissing, not 0, if end with no snow
da75a57
@ashleymedin
change to snow balance is realMissing if never a snow state in the da…
12da1b1 
…ta window, not just at end
@ashleymedin
should have removed these lines for last commit
2d1dfa7
@ashleymedin
change lyr_wght
31faaa4
@ashleymedin
clean up aquiferIni decision
065e137
@ashleymedin
part of last commit
38c053d
@ashleymedin
utils
b3dfc19
@ashleymedin
utils
d9fcaee
@ashleymedin
utils
5dfabef
seantrim and others added 30 commits October 21, 2024 21:37
@seantrim
Merge branch 'develop' of https://github.com/ashleymedin/summa into S…
5c38c01 
…UMMA-ROO
@ashleymedin
name of openWQ module misspelled
9f5b5c1
@seantrim
Fail-safe to avoid an infinite loop for unforeseen errors in split_se…
35afb25 
…lect_loop is now handled via the split_select object (instead of a do loop counter).
@seantrim
Merge branch 'develop' of https://github.com/ashleymedin/summa into S…
8b0984a 
…UMMA-ROO
@seantrim
Applied initialize-update-finalize sequence to opSplittin module subr…
be57e3b 
…outine via internal subroutines.
@seantrim
Added initialize_split, update_split, and finalize_split internal sub…
84a8c64 
…routines to modularize update_opSplittin routine in opSplittin.f90 -- work in progress.
@seantrim
Implementation of initialize_split, update_split, and finalize_split …
298c9c2 
…internal subroutines in opSplittin is now complete and tested.
@ashleymedin
fixing initialize_coupled_em
3e8062f
@seantrim
Simplified treatment of logical flags for control of main loop in opS…
57620ae 
…plittin (split_select_loop).
@seantrim
Merge branch 'develop' of https://github.com/ashleymedin/summa into S…
7593c12 
…UMMA-ROO
@seantrim
Refactoring the main loop in opSplittin using the initialize-update-f…
748f801 
…inalize strategy -- work in progress.
@seantrim
Removed extraneous code and updated comments related to refactoring i…
a7ec124 
…n opSplittin.f90
@seantrim
Updated location of error control for max iterations of split_select_…
6bfe64c 
…loop in opSplittin.f90.
@seantrim
Added intent attribute for firstInnerStep dummy variable in opSplittin.
ecb74c5
@seantrim
Removed unused module use statements and parameterms in opSplittin.f90.
1fae3ef
@seantrim
Cosmetic updates to summa_driver.f90.
206d600
@ashleymedin
Merge pull request #51 from seantrim/SUMMA-ROO
6b9d1df 
Refactoring updates for summa_driver.f90 and opSplittin.f90
@seantrim
Updated stateFilter argument list to utilize split_select object.
de21dbf
@seantrim
Merge branch 'develop' of https://github.com/ashleymedin/summa into S…
3cf0cb7 
…UMMA-ROO
@ashleymedin
Merge pull request #52 from seantrim/SUMMA-ROO
e6a0e27 
Resolving segmentation errors for gcc-13+ builds
@seantrim
Removed nSubset data component from out_stateFilter object -- code us…
a8e71d9 
…ing this object was adapted to use the split_select % nSubset data component.
@seantrim
Removed in_type_stateFilter class and in_stateFilter object -- split_…
17ceb25 
…select object now used instead.
@ashleymedin
Merge pull request #53 from seantrim/SUMMA-ROO
2da57f1 
Simplifying the object-oriented methods used for stateFilter
@seantrim
Updated the initialize-update-finalize structure within summaSolve4ho…
36a08ff 
…megrown.
@ashleymedin
Merge pull request #54 from seantrim/SUMMA-ROO
c0067ee 
Refactoring updates for summaSolve4homegrown
@wknoben
Merge pull request #576 from ashleymedin/develop
9b2fb7f 
Sundials merge, continue
@ashleymedin
capping functions in canopy energy so negative temps inside solver do…
a09eb16 
… not blow up
@ashleymedin
possible for dh to be 0 and cause Nan here
e928e4f
@ashleymedin
expanded veg table size for Ignacio's Plumber data
2f740f4
@wknoben
Merge pull request #577 from ashleymedin/develop
042dc07 
Sundials merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wknoben @ashleymedin @KyleKlenk @seantrim