Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub actions for unit testing in Petals #114

Merged
merged 24 commits into from
Apr 9, 2024
Merged

Conversation

peanutfun
Copy link
Member

@peanutfun peanutfun commented Feb 23, 2024

Changes proposed in this PR:

  • Create a workflow that installs Core and Petals, and runs unit tests on Petals

This is slightly different from the Core setup in that we use a "reusable workflow" testing.yml. This way, we can trigger the workflow from the Core repository as well. This achieves compatibility testing for changes in Core.

PR Author Checklist

PR Reviewer Checklist

@peanutfun peanutfun marked this pull request as ready for review April 5, 2024 14:32
@chahank
Copy link
Member

chahank commented Apr 8, 2024

As a non-expert on github actions, I looked at it and I have nothing to add :). Thanks for making this work!

Maybe @emanuel-schmid has something to add?

@emanuel-schmid
Copy link
Contributor

@chahank : not me 😄 I just merge it then we'll see.

@emanuel-schmid emanuel-schmid merged commit 0b4e1f1 into develop Apr 9, 2024
11 checks passed
@emanuel-schmid emanuel-schmid deleted the github-actions branch April 15, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants