Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GitHub CI execute unit tests in Petals via reusable workflow #855

Merged
merged 13 commits into from
May 15, 2024

Conversation

peanutfun
Copy link
Member

@peanutfun peanutfun commented Feb 23, 2024

Changes proposed in this PR:

PR Author Checklist

PR Reviewer Checklist

@peanutfun peanutfun marked this pull request as ready for review April 10, 2024 09:40
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@peanutfun peanutfun requested a review from chahank April 30, 2024 08:54
@peanutfun
Copy link
Member Author

Petals Compatibility tests are failing because we are testing against Petal's develop. Should be fixed by switching to the centroids branch or by waiting until CLIMADA-project/climada_petals#122 is merged.

@emanuel-schmid emanuel-schmid merged commit cdcb6ae into develop May 15, 2024
18 checks passed
@emanuel-schmid emanuel-schmid deleted the improve-github-workflow branch May 15, 2024 07:50
gdeskos pushed a commit to gdeskos/climada_python that referenced this pull request Sep 16, 2024
…IMADA-project#855)

* State storage directories for coverage reports

* Call Petals workflow from Core

* ci: Fix indentation

* ci: Only execute Petals tests if core succeeds

* ci: Use specific SHA for petals pipeline

* Revert "ci: Use specific SHA for petals pipeline"

This reverts commit 8037e6f.

* Rename checks and results

Add TODO for updating branch ref after the corresponding Petals PR is
merged.

* Update CHANGELOG.md

* Switch to Petals develop branch version of reusable workflow

* Rename 'Unit Tests' job to 'Unit Test Pipeline'

... to better distringuish from the test result.

* Switch branch for accessing Petals workflow

---------

Co-authored-by: emanuel-schmid <schmide@ethz.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants