Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests on aarch64 #266

Merged
merged 2 commits into from
Apr 18, 2019
Merged

fix tests on aarch64 #266

merged 2 commits into from
Apr 18, 2019

Conversation

ryan4729
Copy link
Contributor

This fixes HelpersTest on aarch64. The test assumed that the char type is always signed, but on aarch64 it's unsigned by default.

@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #266 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #266   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        2737   2737           
=====================================
  Hits         2737   2737

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76d2cde...b7b8ef1. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #266 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #266   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines        2737   2737           
=====================================
  Hits         2737   2737

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76d2cde...b7b8ef1. Read the comment docs.

@henryiii henryiii merged commit 734af66 into CLIUtils:master Apr 18, 2019
@henryiii
Copy link
Collaborator

Great, thanks!

@ryan4729 ryan4729 deleted the aarch64-tests branch April 18, 2019 18:37
@henryiii henryiii added this to the v1.8 milestone Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants