Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tests on aarch64 #266

Merged
merged 2 commits into from
Apr 18, 2019
Merged

fix tests on aarch64 #266

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8aeaab7
fix tests on aarch64
Apr 18, 2019
b7b8ef1
lint
Apr 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions tests/HelpersTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#include "app_helper.hpp"

#include <climits>
#include <complex>
#include <cstdint>
#include <cstdio>
Expand Down Expand Up @@ -553,8 +554,8 @@ TEST(Types, TypeName) {
}

TEST(Types, OverflowSmall) {
char x;
auto strmax = std::to_string(INT8_MAX + 1);
signed char x;
auto strmax = std::to_string(SCHAR_MAX + 1);
EXPECT_FALSE(CLI::detail::lexical_cast(strmax, x));

unsigned char y;
Expand Down Expand Up @@ -641,7 +642,7 @@ TEST(Types, LexicalCastParsable) {
}

TEST(Types, LexicalCastEnum) {
enum t1 : char { v1 = 5, v3 = 7, v5 = -9 };
enum t1 : signed char { v1 = 5, v3 = 7, v5 = -9 };

t1 output;
EXPECT_TRUE(CLI::detail::lexical_cast("-9", output));
Expand Down