Easi 4528/query links #2957
Merged
Easi 4528/query links #2957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EKS Ingress URLs |
ClayBenson94
approved these changes
Jan 22, 2025
samoddball
merged commit 166851d
into
feature/EASI-4521_grb_presentation_links
14 checks passed
patrickseguraoddball
added a commit
that referenced
this pull request
Feb 24, 2025
* Init feature branch * [EASI-4527] add presentation links schema (#2951) * add presentation links schema * move column declarations * add presentation links model and stub URL/status resolvers, remove bucket name * add mutation/query to postman * [EASI-4529] notification emails (#2947) * email template * create template support code * add to tests * use acronym * Update pkg/email/templates/grb_review_presentation_links_updated.gohtml Co-authored-by: Lee Warrick <32332479+mynar7@users.noreply.github.com> * remove extra <br> * updates to system_intake_admin_upload_doc.gohtml * fix oops * fix mistaken bold * spacing --------- Co-authored-by: Lee Warrick <32332479+mynar7@users.noreply.github.com> * Easi 4697/delete links mutation (#2953) * add sql file, sqlqueries file, storage file * add to schema/resolvers * err when row not found * whoops * add some form of a test * [EASI-4711] Remove required presentation links fields (#2954) * remove requirement * add semicolon * Easi 4528/query links (#2957) * working on dataloaders + storage * app code should be done, working on tests * remove mock code * add quick test to be expanded on later * remove todos * [EASI-4531] GRB presentation links form (#2972) * Form component and route * Basic form fields * Presentation links mutation * Update fields type to match mutation * Form submit * Transcript fields tabs * Update allowed file types * Fix field bugs * Field validation * Edit form default values * FileInput component with defaultFileName prop * Disable form if no fields changed * Basic unit tests * Basic unit tests * Tab field updates * Fix routes * Update props * Prop typo fix * Update file field values to base64 * Bug fixes * Fix TS error * Update variable name * FileInput unit test * Fix disabled submit button on edit - Submit button was disabled on edit if presentation deck file was previously uploaded, and a different field was updated - Updated form to set default values for file upload fields * Fix transcript fields default tab * Fix mobile view grid layout * [EASI-4696] create/update links (#2966) * working on upsert functionality * wire up resolver to storage method` * initial tests - will rework the entire testing file to be cohesive * test upsert * combine tests and clean up * confirm err occurs when adding conflicting fields * add one devdata piece - testing * add other type of links in devdata * use links again - oops * whoops - remove disallowed combination * return data from sql, fix sql statement * move to resolvers pkg, add s3 functionality * fix up resolver, add file handler helper, add test * nill transcript link when either file has data * eanup easiencoding pkg * don't overwrite initial config * add comment, better naming. handle modifierd by/at * add test * update both url schema resolvers * updates to hardcoded resolvers * starting on omittable * fix check * whoops * those aren't errors either! * remove unused * add omittable to other fields * experimenting with removing files * fix comments * fix comment * move resolver code to resolver file * Fix incorrect resolver hooked up on presentation deck which was incorrectly pointed to transcript * chore: correct migration linting * EASI-4530 Grb async presentation links card (#2958) * Async presentation card stub * Modal to remove presentation links * Interactions for demo Icons * `SystemIntake.grbPresentationLinks` type and display prop values * `DeleteSystemIntakeGRBPresentationLinks` fe mutation * PresentationLinksCard component * PresentationLinksCard unit tests * Error handle delete modal Spread more link props * Render switch over admin context * ExternalLinkModal in PresentationLinksCard * Virus scanning * Hide card form links if not admin * Fix virus scanning text * Unit test fix * GRB reviewer view * CardHeader padding * Add transcript link to query and card * No recording link available text * Presentation link spacing / util classes - Updated link spacing in card - Added util classes for 'gap', 'row-gap', and 'column-gap' css properties * Refetch intake after delete mutation * Use <ExternalLinkAndModal> for external links - Replaced external link modal handling code with <ExternalLinkAndModal> component - Fixed icon spacing on external link button * Fix empty card conditional rendering * Spacing * Unit tests * chore: return nil error if status cant be returned for docs. log warning of the error * chore: correct pointer de-reference in logger --------- Co-authored-by: Ashley Terstriep <60187543+aterstriep@users.noreply.github.com> Co-authored-by: Clay Benson <clay.benson@oddball.io> Co-authored-by: Steven Wade <steven.wade@oddball.io> * [EASI-4715] Async GRB presentation links form fixes (#3008) * Clear transcript file if link exists * Update backend to nil out transcript file data when uploading a link * Only clear out transcript file data if passing a non-nil value for the link * Clear default file data * Field validation updates * Validation unit tests * recordingLink input type --------- Co-authored-by: ClayBenson94 <clay.benson@oddball.io> Co-authored-by: samoddball <156127704+samoddball@users.noreply.github.com> * Added cypress test --------- Co-authored-by: samoddball <156127704+samoddball@users.noreply.github.com> Co-authored-by: Clay Benson <clay.benson@oddball.io> Co-authored-by: Lee Warrick <32332479+mynar7@users.noreply.github.com> Co-authored-by: Ashley Terstriep <60187543+aterstriep@users.noreply.github.com> Co-authored-by: Steven Wade <99294987+StevenWadeOddball@users.noreply.github.com> Co-authored-by: Steven Wade <steven.wade@oddball.io> Co-authored-by: Patrick Segura <patrick.segura@oddball.io> Co-authored-by: Patrick Segura <95709965+patrickseguraoddball@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EASI-4528
Description
How to test this change
PR Author Checklist
PR Reviewer Guidelines