EASI-4530 Grb async presentation links card

[adamodd]

EASI-4530

Description

• New PresentationLinksCard.tsx

Please keep in mind there is another ticket in this feature for more testing in case there are substantial change requests.

How to test this change

• New PresentationLinksCard.test.tsx

PR Author Checklist

• I have provided a detailed description of the changes in this PR.
• I have provided clear instructions on how to test the changes in this PR.
• I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

• It's best to pull the branch locally and test it, rather than just looking at the code online!
• When approving a PR, provide a reason why you're approving it
  • e.g. "Approving because I tested it locally and all functionality works as expected"
  • e.g. "Approving because the change is simple and matches the Figma design"
• Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
• Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

[github-actions]

EKS Ingress URLs

• EASi
• Mailcatcher
• Minio Console

[aterstriep]

• It looks like the "virus scanning in progress" view from the Figma is missing
• Action buttons should be hidden for GRB reviewer view
  • I think it's worth adding both this and the virus scanning view to the unit tests
• I noticed a couple things on the mobile view:
  • You might want to double check with Zoe on this, but the "Remove all presentation links" button is not displayed on mobile
  • The links should all be on separate lines (see screenshot of current state below)

[aterstriep]

You might want to double check with Zoe on this, but the "Remove all presentation links" button is not displayed on mobile

I also asked Zoe about this and she said the "Remove all presentation links" button should display on mobile

[patrickseguraoddball]

I'm able to submit empty presentation links by setting the recording link, then removing that the link before submission. This is the payload

{
  "input": {
    "systemIntakeID": "9ab475a8-a691-45e9-b55d-648b6e752efa",
    "recordingLink": "",
    "recordingPasscode": "",
    "transcriptLink": ""
  }
}

I seerecordingLink is not required in the schema, but I was under the impression that it was required in the form. Can this be confirmed? Either way, the form is able to be submitted without any input data, and the card is also rendered empty on the admin page

After adding a file, the card is set to Virus scanning in progress. Then I go into the form and remove the file. The card on the admin page is still showing Virus scanning in progress

Additionaly, I cannot submit the form without editing the recording link. For example, I've added a recording link and uploaded a file. When I go to edit the presentation links, and I only want to remove the file, I also need to edit the recording link to be able to submit the form.

I'm also able to submit the form with only a recording passcode, but not recording link

I'm getting an error when trying to add a transcript link.

{
  "errors": [
    {
      "message": "pq: new row for relation \"system_intake_grb_presentation_links\" violates check constraint \"transcript_link_or_doc_null_check\"",
      "path": [
        "setSystemIntakeGRBPresentationLinks"
      ]
    }
  ],
  "data": {
    "setSystemIntakeGRBPresentationLinks": null
  }

[aterstriep]

@patrickseguraoddball There is still some remaining work to be done on the form in EASI-4715. There were additional changes to the schema and backend resolvers after the initial form PR went through, so I need to update the form code to fix the submit mutation issues.

If there are any card states that you want to test locally that aren't possible using the form, you could mock the presentation links prop here (there is existing mock data here).

Most of the issues are with editing the form, so you can also just remove all presentation links to clear the links before submitting new data. I'm also happy to sync on this to run through the different card states.

[patrickseguraoddball]

LG thanks!