-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BFD-3732: Create migration script for SAMHSA 2.0 tables #2480
Draft
dondevun
wants to merge
18
commits into
master
Choose a base branch
from
BFD-3732
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+105
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cause of the missing data such as pbp number for Oct and Dec (#2475)
Co-authored-by: aschey-forpeople <162160982+aschey-forpeople@users.noreply.github.com>
Co-authored-by: Mitch Alessio <mitch.alessio@forpeople.us>
dondevun
requested review from
mjburling,
aschey-forpeople and
malessi
as code owners
November 6, 2024 14:39
MahiFentaye
reviewed
Nov 6, 2024
...bfd-model-rif/src/main/resources/db/migration/V20241101111900986__create_samhsa_2_tables.sql
Show resolved
Hide resolved
MahiFentaye
previously approved these changes
Nov 6, 2024
...bfd-model-rif/src/main/resources/db/migration/V20241101111900986__create_samhsa_2_tables.sql
Outdated
Show resolved
Hide resolved
...bfd-model-rif/src/main/resources/db/migration/V20241101111900986__create_samhsa_2_tables.sql
Outdated
Show resolved
Hide resolved
aschey-forpeople
previously approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but just FYI you can add the constraints inline and the indexes without an explicit name so you don't have to worry about typos in the constraint and index names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BFD-3732
What Does This PR Do?
Adds the necessary tables for the SAMHSA 2.0 filter.
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Adds any new software dependencies
Modifies any security controls
Adds new transmission or storage of data
Any other changes that could possibly affect security?
I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (
@sb-benohe
) approval.)Validation
Migrator successfully tested on ephemeral database.