Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BFD-3732: Create migration script for SAMHSA 2.0 tables #2480

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

dondevun
Copy link
Contributor

@dondevun dondevun commented Nov 5, 2024

JIRA Ticket:
BFD-3732

What Does This PR Do?

Adds the necessary tables for the SAMHSA 2.0 filter.

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies

  • Modifies any security controls

  • Adds new transmission or storage of data

  • Any other changes that could possibly affect security?

  • I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (@sb-benohe) approval.)

Validation

Migrator successfully tested on ephemeral database.

@dondevun dondevun marked this pull request as ready for review November 6, 2024 14:39
MahiFentaye
MahiFentaye previously approved these changes Nov 6, 2024
Copy link
Contributor

@aschey-forpeople aschey-forpeople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but just FYI you can add the constraints inline and the indexes without an explicit name so you don't have to worry about typos in the constraint and index names.

@dondevun dondevun marked this pull request as draft November 12, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants