Skip to content

Merge pull request #135 from COMBINE-lab/master #443

Merge pull request #135 from COMBINE-lab/master

Merge pull request #135 from COMBINE-lab/master #443

Triggered via push February 15, 2024 21:00
Status Failure
Total duration 3m 2s
Artifacts

rust.yml

on: push
Matrix: build
Matrix: Formatting
Matrix: Linting
Matrix: sample_run
Fit to window
Zoom out
Zoom in

Annotations

4 errors and 14 warnings
redundant redefinition of a binding `bc_type`: src/quant.rs#L640
error: redundant redefinition of a binding `bc_type` --> src/quant.rs:640:9 | 640 | let bc_type = bc_type; | ^^^^^^^^^^^^^^^^^^^^^^ | help: `bc_type` is initially defined here --> src/quant.rs:538:9 | 538 | let bc_type = rad_types::decode_int_type_tag(bct).expect("unsupported barcode type id."); | ^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals = note: `#[deny(clippy::redundant_locals)]` on by default
redundant redefinition of a binding `umi_type`: src/quant.rs#L641
error: redundant redefinition of a binding `umi_type` --> src/quant.rs:641:9 | 641 | let umi_type = umi_type; | ^^^^^^^^^^^^^^^^^^^^^^^^ | help: `umi_type` is initially defined here --> src/quant.rs:539:9 | 539 | let umi_type = rad_types::decode_int_type_tag(umit).expect("unsupported umi type id."); | ^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_locals
Linting (ubuntu-latest)
Clippy had exited with the 101 exit code
Linting (macos-latest)
The job was canceled because "ubuntu-latest" failed.
Formatting (ubuntu-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Linting (ubuntu-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs-plus/clippy-check@cbcfbff5103c40b26d7077f164f0ec6052036081. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Linting (ubuntu-latest)
Unexpected input(s) 'token', valid inputs are ['toolchain', 'args', 'use-cross']
explicit call to `.into_iter()` in function argument accepting `IntoIterator`: src/collate.rs#L121
warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> src/collate.rs:121:38 | 121 | let mut tsv_map = Vec::from_iter(freq_hm.into_iter()); | ^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `freq_hm` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/iter/traits/collect.rs:150:21 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
use of `or_insert_with` to construct default value: src/pugutils.rs#L297
warning: use of `or_insert_with` to construct default value --> src/pugutils.rs:297:46 | 297 | let ve = components.entry(*v as u32).or_insert_with(Vec::new); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default = note: `#[warn(clippy::unwrap_or_default)]` on by default
use of `or_insert_with` to construct default value: src/pugutils.rs#L818
warning: use of `or_insert_with` to construct default value --> src/pugutils.rs:818:42 | 818 | let umis = tmp_map.entry(vert.0).or_insert_with(Vec::new); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
call to `reserve` immediately after creation: src/utils.rs#L564
warning: call to `reserve` immediately after creation --> src/utils.rs:564:5 | 564 | / let mut snps: Vec<u64> = Vec::new(); 565 | | snps.reserve(3 * bc_length); | |________________________________^ help: consider using `Vec::with_capacity(/* Space hint */)`: `let mut snps: Vec<u64> = Vec::with_capacity(3 * bc_length);` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#reserve_after_initialization = note: `#[warn(clippy::reserve_after_initialization)]` on by default
call to `reserve` immediately after creation: src/utils.rs#L593
warning: call to `reserve` immediately after creation --> src/utils.rs:593:5 | 593 | / let mut indels: Vec<u64> = Vec::new(); 594 | | indels.reserve(8 * (bc_length - 1)); | |________________________________________^ help: consider using `Vec::with_capacity(/* Space hint */)`: `let mut indels: Vec<u64> = Vec::with_capacity(8 * (bc_length - 1));` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#reserve_after_initialization
useless use of `vec!`: src/convert.rs#L45
warning: useless use of `vec!` --> src/convert.rs:45:16 | 45 | let nucl = vec!["A", "T", "G", "C"]; | ^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["A", "T", "G", "C"]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec = note: `#[warn(clippy::useless_vec)]` on by default
build (ubuntu-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Formatting (macos-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
sample_run (ubuntu-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
build (macos-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
sample_run (macos-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.