Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs-plus/clippy-check@cbcfbff5103c40b26d7077f164f0ec6052036081. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Linting (ubuntu-latest)

Unexpected input(s) 'token', valid inputs are ['toolchain', 'args', 'use-cross']

you don't need to add `&` to all patterns: src/cellfilter.rs#L290

warning: you don't need to add `&` to all patterns --> src/cellfilter.rs:290:23 | 290 | let barcode_len = match barcode_tag { | _______________________^ 291 | | &TagValue::U8(x) => x as u16, 292 | | &TagValue::U16(x) => x, 293 | | &TagValue::U32(x) => x as u16, 294 | | &TagValue::U64(x) => x as u16, 295 | | _ => bail!("unexpected tag type"), 296 | | }; | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats = note: `#[warn(clippy::match_ref_pats)]` on by default help: instead of prefixing all patterns with `&`, you can dereference the expression | 290 ~ let barcode_len = match *barcode_tag { 291 ~ TagValue::U8(x) => x as u16, 292 ~ TagValue::U16(x) => x, 293 ~ TagValue::U32(x) => x as u16, 294 ~ TagValue::U64(x) => x as u16, |

you don't need to add `&` to all patterns: src/cellfilter.rs#L482

warning: you don't need to add `&` to all patterns --> src/cellfilter.rs:482:23 | 482 | let barcode_len = match barcode_tag { | _______________________^ 483 | | &TagValue::U8(x) => x as u16, 484 | | &TagValue::U16(x) => x, 485 | | &TagValue::U32(x) => x as u16, 486 | | &TagValue::U64(x) => x as u16, 487 | | _ => bail!("unexpected tag type"), 488 | | }; | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 482 ~ let barcode_len = match *barcode_tag { 483 ~ TagValue::U8(x) => x as u16, 484 ~ TagValue::U16(x) => x, 485 ~ TagValue::U32(x) => x as u16, 486 ~ TagValue::U64(x) => x as u16, |

explicit call to `.into_iter()` in function argument accepting `IntoIterator`: src/collate.rs#L126

warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` --> src/collate.rs:126:38 | 126 | let mut tsv_map = Vec::from_iter(freq_hm.into_iter()); | ^^^^^^^^^^^^^^^^^^^ help: consider removing the `.into_iter()`: `freq_hm` | note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` --> /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/iter/traits/collect.rs:150:21 = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

you don't need to add `&` to all patterns: src/convert.rs#L552

warning: you don't need to add `&` to all patterns --> src/convert.rs:552:23 | 552 | let barcode_len = match barcode_tag { | _______________________^ 553 | | &TagValue::U8(x) => x as u16, 554 | | &TagValue::U16(x) => x, 555 | | &TagValue::U32(x) => x as u16, 556 | | &TagValue::U64(x) => x as u16, 557 | | _ => bail!("unexpected tag type"), 558 | | }; | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 552 ~ let barcode_len = match *barcode_tag { 553 ~ TagValue::U8(x) => x as u16, 554 ~ TagValue::U16(x) => x, 555 ~ TagValue::U32(x) => x as u16, 556 ~ TagValue::U64(x) => x as u16, |

you don't need to add `&` to all patterns: src/convert.rs#L561

warning: you don't need to add `&` to all patterns --> src/convert.rs:561:19 | 561 | let umi_len = match umi_tag { | ___________________^ 562 | | &TagValue::U8(x) => x as u16, 563 | | &TagValue::U16(x) => x, 564 | | &TagValue::U32(x) => x as u16, 565 | | &TagValue::U64(x) => x as u16, 566 | | _ => bail!("unexpected tag type"), 567 | | }; | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 561 ~ let umi_len = match *umi_tag { 562 ~ TagValue::U8(x) => x as u16, 563 ~ TagValue::U16(x) => x, 564 ~ TagValue::U32(x) => x as u16, 565 ~ TagValue::U64(x) => x as u16, |

this expression creates a reference which is immediately dereferenced by the compiler: src/io_utils.rs#L166

warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/io_utils.rs:166:17 | 166 | &record_context, | ^^^^^^^^^^^^^^^ help: change this to: `record_context` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

use of `or_insert_with` to construct default value: src/pugutils.rs#L298

warning: use of `or_insert_with` to construct default value --> src/pugutils.rs:298:46 | 298 | let ve = components.entry(*v as u32).or_insert_with(Vec::new); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default = note: `#[warn(clippy::unwrap_or_default)]` on by default

use of `or_insert_with` to construct default value: src/pugutils.rs#L819

warning: use of `or_insert_with` to construct default value --> src/pugutils.rs:819:42 | 819 | let umis = tmp_map.entry(vert.0).or_insert_with(Vec::new); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default

you don't need to add `&` to all patterns: src/quant.rs#L488

warning: you don't need to add `&` to all patterns --> src/quant.rs:488:23 | 488 | let barcode_len = match barcode_tag { | _______________________^ 489 | | &TagValue::U8(x) => x as u16, 490 | | &TagValue::U16(x) => x, 491 | | &TagValue::U32(x) => x as u16, 492 | | &TagValue::U64(x) => x as u16, 493 | | _ => bail!("unexpected tag type"), 494 | | }; | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats help: instead of prefixing all patterns with `&`, you can dereference the expression | 488 ~ let barcode_len = match *barcode_tag { 489 ~ TagValue::U8(x) => x as u16, 490 ~ TagValue::U16(x) => x, 491 ~ TagValue::U32(x) => x as u16, 492 ~ TagValue::U64(x) => x as u16, |

Linting (macos-latest)