Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix README.md and quickstart.md #654

Merged
merged 2 commits into from
Nov 15, 2024
Merged

docs: fix README.md and quickstart.md #654

merged 2 commits into from
Nov 15, 2024

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Nov 15, 2024

No description provided.

@ss2165 ss2165 requested a review from a team as a code owner November 15, 2024 14:47
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.49%. Comparing base (3d74156) to head (a8da392).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #654   +/-   ##
=======================================
  Coverage   92.49%   92.49%           
=======================================
  Files          66       66           
  Lines        7503     7503           
=======================================
  Hits         6940     6940           
  Misses        563      563           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mark-koch mark-koch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

Btw, the readme is also broken...

version = "0.13.0"
version = "0.13.1"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this coming from?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release please workflow doesn't update uv lock so when a release happens the subsequent PR will cause a guppylang uv lock bump

@ss2165 ss2165 changed the title docs: fix quickstart.md docs: fix README.md and quickstart.md Nov 15, 2024
@ss2165 ss2165 added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit abb0221 Nov 15, 2024
4 checks passed
@ss2165 ss2165 deleted the ss/quickstart branch November 15, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants