fix: Fix implicit modules in IPython shells #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-koch
force-pushed
the
fix/ipython
branch
from
56ab8da
to
40c36b0
Compare
mark-koch
commented
Nov 25, 2024
Comment on lines
+15
to
+24
| def is_ipython_dummy_file(filename: str) -> bool: | ||
| """Checks whether a given filename is a dummy name generated for an IPython cell.""" | ||
| # TODO: The approach below is false-positive prone. Figure out if there is a better | ||
| # way to do this. | ||
| return ( | ||
| # IPython cells have filenames like "<ipython-input-3-3e9b5833de21>" | ||
| filename.startswith("<ipython-input-") | ||
| # Jupyter cells have filenames like "/var/{...}/ipykernel_82076/61218616.py" | ||
| or "ipykernel_" in filename | ||
| ) |
There was a problem hiding this comment.
I'm not really happy with this, but I don't know a better way to solve this problem :/
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #662 +/- ##
==========================================
- Coverage 92.49% 92.48% -0.02%
==========================================
Files 66 66
Lines 7503 7505 +2
==========================================
+ Hits 6940 6941 +1
- Misses 563 564 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
cqc-alec
approved these changes
Nov 25, 2024
|
(The only difference between the generated hugr when run in ipython with this fix and when run as a python script is that the Module metadata is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #661