Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update collections extension #1518

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix: Update collections extension #1518

merged 1 commit into from
Sep 3, 2024

Conversation

aborgna-q
Copy link
Collaborator

Broken in #1513, it's failing on main

Should we make this a required check?

@aborgna-q aborgna-q requested a review from a team as a code owner September 3, 2024 17:07
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.27%. Comparing base (4cbe890) to head (e13f24c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1518   +/-   ##
=======================================
  Coverage   87.27%   87.27%           
=======================================
  Files         128      128           
  Lines       21718    21718           
  Branches    18718    18718           
=======================================
  Hits        18955    18955           
  Misses       1990     1990           
  Partials      773      773           
Flag Coverage Δ
python 92.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mark-koch mark-koch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make this a required check?

Yes I think so, this is easy to forget

@aborgna-q aborgna-q added this pull request to the merge queue Sep 3, 2024
Merged via the queue into main with commit 60e1da0 Sep 3, 2024
20 checks passed
@aborgna-q aborgna-q deleted the ab/fix-collection-exts branch September 3, 2024 17:23
github-merge-queue bot pushed a commit that referenced this pull request Sep 4, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 4, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.8.1](hugr-py-v0.8.0...hugr-py-v0.8.1)
(2024-09-04)


### Features

* Export the collections extension
([#1506](#1506))
([70e0a64](70e0a64))


### Bug Fixes

* Export the float ops extension
([#1517](#1517))
([4cbe890](4cbe890))
* IndexError on node slicing
([#1500](#1500))
([a32bd84](a32bd84))
* Update collections extension
([#1518](#1518))
([60e1da0](60e1da0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants